Closed
Bug 822686
Opened 12 years ago
Closed 11 years ago
java.lang.NullPointerException: at org.mozilla.gecko.Favicons$LoadFaviconTask.downloadFavicon(Favicons.java)
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox19 wontfix, firefox20 wontfix, firefox21 fixed, firefox22 fixed)
RESOLVED
FIXED
Firefox 22
People
(Reporter: scoobidiver, Assigned: cpeterson)
References
Details
(Keywords: crash, regression, Whiteboard: [native-crash])
Crash Data
Attachments
(1 file)
4.41 KB,
patch
|
mfinkle
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
There are one crash in 20.0a1/20121218, bp-e395e6fe-b018-4596-bdbc-6ca6b2121218, and two crashes in 19.0a2. java.lang.NullPointerException at org.mozilla.gecko.Favicons$LoadFaviconTask.downloadFavicon(Favicons.java:225) at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:297) at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:182) at android.os.AsyncTask$2.call(AsyncTask.java:287) at java.util.concurrent.FutureTask.run(FutureTask.java:234) at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:230) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573) at java.lang.Thread.run(Thread.java:856) More reports at: https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.Favicons%24LoadFaviconTask.downloadFavicon%28Favicons.java%29
Reporter | ||
Updated•11 years ago
|
Reporter | ||
Updated•11 years ago
|
status-firefox22:
--- → affected
Assignee | ||
Comment 1•11 years ago
|
||
Lucas, can mContext be null on line 244 here? GeckoJarReader.getBitmapDrawable() can return null, but if that was the cause of the crash, I would expect the stack trace to point to line 245. https://hg.mozilla.org/mozilla-central/annotate/47876c1d1c45/mobile/android/base/Favicons.java#l244
Assignee | ||
Comment 2•11 years ago
|
||
I think null BitmapDrawable is the problem. In the following bug's raw dump, GeckoJarReader logs a "file not found" error. https://crash-stats.mozilla.com/report/index/8ae4272a-6ee3-4ce7-bbb0-92cff2130226 java.io.FileNotFoundException: /data/app/org.mozilla.firefox_beta-1.apk: open failed: ENOENT (No such file or directory) at libcore.io.IoBridge.open(IoBridge.java:416) at java.io.RandomAccessFile.<init>(RandomAccessFile.java:118) at java.io.RandomAccessFile.<init>(RandomAccessFile.java:150) at java.util.zip.ZipFile.<init>(ZipFile.java:130) at java.util.zip.ZipFile.<init>(ZipFile.java:103) at org.mozilla.gecko.util.GeckoJarReader.getZipFile(GeckoJarReader.java:104) at org.mozilla.gecko.util.GeckoJarReader.getBitmapDrawable(GeckoJarReader.java:39) at org.mozilla.gecko.Favicons$LoadFaviconTask.downloadFavicon(Favicons.java:252) at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:325) at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:207) at android.os.AsyncTask$2.call(AsyncTask.java:287) at java.util.concurrent.FutureTask.run(FutureTask.java:234) at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:230) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573) at java.lang.Thread.run(Thread.java:856)
Assignee | ||
Comment 3•11 years ago
|
||
Check for null return from getBitmapDrawable() and consolidate null checks into new getBitmap() utility method.
Comment 4•11 years ago
|
||
Comment on attachment 721187 [details] [diff] [review] handle-null-bitmapdrawable.patch Nice cleanup and fix
Attachment #721187 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4afd31d13e7f
Target Milestone: --- → Firefox 22
Reporter | ||
Updated•11 years ago
|
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4afd31d13e7f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 721187 [details] [diff] [review] handle-null-bitmapdrawable.patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 808027 User impact if declined: Low volume crash. 90% of these crashes are in Firefox 19, so some code change in Beta 20 greatly reduced the volume of this crash, but it continues in Aurora 21 and Nightly 22. Testing completed (on m-c, etc.): Local testing. Risk to taking this patch (and alternatives if risky): Low risk patch that adds a null check (and adds a new function to make null checking easier) String or UUID changes made by this patch: None
Attachment #721187 -
Flags: approval-mozilla-aurora?
Comment 8•11 years ago
|
||
Comment on attachment 721187 [details] [diff] [review] handle-null-bitmapdrawable.patch null check, avoids rare crashes on aurora.Approving for uplift.
Attachment #721187 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/7ad686d04fa3
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•