823026 - Profiler is not themable. CSS and images should be placed in /skin/

Status: RESOLVED WONTFIX

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Alfred Kayser]

The profiler added to Firefox Development Tools in bug 795268 is not themeable.

Theme files should have been placed in /skin/:
chrome://browser/content/profiler.css
/browser/devtools/profiler/cleopatra/css/ *
etc...

Comment 1

[mcdavis941 (sporadically reading bugmail)]

Yes, please.

Comment 2

[Alfred Kayser]

Attachment: WIP: Patch to rearaange the profiler theme files to brower/skin/devtools

Comment 3

[Alfred Kayser]

Note, the other changes in the *.css files should be covered in bug 822110 (removal of the enmpty noise.png, as well as the -webkit- and -moz- lines)

Comment 4

[Alfred Kayser]

Attachment: V2: correct more issues in .css files, and correctly include profiler.css

Comment 5

[Rob Campbell [:rc] (:robcee)]

this is actually not a trivial thing to do currently.

The Profiler UI aka Cleopatra is from an upstream project, notably:

https://github.com/robcee/cleopatra

As new features are added to the Gecko profiler, they're reflected in Cleopatra. If we want to continue updating from that, we'll need to update our in-tree version with changes from that repo. Splitting out the styling would break those updates currently.

We may get to a point where we're hosting the definitive version of Cleopatra at which point we can do theme-specific things with it, but until that time, we're stuck with this UI.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 694277 [details] [diff] [review]
V2: correct more issues in .css files, and correctly include profiler.css

canceling review for now.

also, I linked to my fork of the canonical repository which is located here:

https://github.com/bgirard/cleopatra

Comment 7

[Alfred Kayser]

Can I at least request that the stylesheets and images to be placed in /skin/?

Comment 8

[Rob Campbell [:rc] (:robcee)]

Unfortunately the styling is going to be hard to separate.

Benoit, Anton, what do you guys think about hosting the styling for cleo-light in mozilla-central?