823416 - [Dialer] No response when answer/hang up/redial from bluetooth handsfree

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P3)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

Since the property name of system message is changed, we need to update Dialer app, too.

Topic: "bluetooth-dialer-command"
Original message: {"bluetooth-dialer-command":"ATA"}
New message: {"command":"ATA"}

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB-, tracking-b2g18+. decided not to support BT handsfree action button for v1

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

refer to bug 820655 for de-scope decision

Comment 3

[Eric Chou [:ericchou] [:echou]]

I would like to renominate this as a bb+, because if this issue is not fixed, most HFP functions won't work. The user will be unable to answer a call, hang up, or redial.

The root cause of this bug are two. First, Gina found a typo of the topic of system messages sent from Gecko Bluetooth. About the same time, Gina had finished her work for bug 820103, which would send an "ATD" command to Dialer with a phone number supplied with remote Bluetooth headset. Both of these need some modification in Dialer. So Gina revised both, pushed, and filed bug 823416.

I believe the patch of the bug will be a fairly low-risk revision.

Comment 4

[David Scravaglieri [:scravag]]

Chris could you confirm this is not for V1 ?

Comment 5

[Peter Dolanjski [:pdol]]

I spoke with clee about this.
While we will not support many of the HFP functions for v1, without this fix, basic functionality (like answering a call) will not work.  
Eric, is a patch ready for this?

Comment 6

[Eric Chou [:ericchou] [:echou]]

(In reply to Peter Dolanjski from comment #5)
> I spoke with clee about this.
> While we will not support many of the HFP functions for v1, without this
> fix, basic functionality (like answering a call) will not work.  
> Eric, is a patch ready for this?

Yes, we've got a solution. Rudy will take over this.

Eric

Comment 7

[Eric Chou [:ericchou] [:echou]]

(In reply to Peter Dolanjski from comment #5)
> I spoke with clee about this.
> While we will not support many of the HFP functions for v1, without this
> fix, basic functionality (like answering a call) will not work.  

Chris is right, we won't be able to answer a call/hang up a call/redial without fixing this.

Should I renominate as a bb+ to ensure this will be checked into b2g-18?

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7182/commits

Pointer to Github pull-request

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

Triage: agree with comment 5. BB+

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7182/files

Pointer to Github pull-request

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 695574 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7182/commits

Evelyn, please help review this patch.
Thanks.

Comment 12

[Evelyn Hung]

Comment on attachment 695574 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7182/commits

r=me, please update correct message from Gecko here, so the code will be synced with this issue.

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Fixed with,
https://github.com/mozilla-b2g/gaia/commit/d49894d7465af21a5c24167e09c58edf56026b26

Evelyn, thank you for the review.

Comment 14

[Walter Chen[:ypwalter][:wachen]]

Verified fix in pvt build 2013-1-3