Closed
Bug 823446
Opened 11 years ago
Closed 11 years ago
Fix 'Services.appshell', should be 'Services.appShell' (documentation was wrong)
Categories
(Calendar :: Internal Components, defect)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
FIXED
2.1
People
(Reporter: aryx, Assigned: aryx)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
1.17 KB,
patch
|
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/comm-central/source/calendar/resources/content/calendarService.js#119 has w = Services.appshell.hiddenDOMWindow; which should be w = Services.appShell.hiddenDOMWindow; The documentation was wrong on this :/. Upcoming patch.
Assignee | ||
Comment 1•11 years ago
|
||
You will have to transplant the patch to comm-aurora and comm-beta.
Attachment #694289 -
Flags: review?(philipp)
Assignee | ||
Comment 2•11 years ago
|
||
Fallen, if you don't want to ship this bug in a week, this needs to be fixed/reviewed as soon as possible.
Flags: needinfo?(philipp)
Comment 3•11 years ago
|
||
The file doesn't seem to be shipped with Lightning, i.e. only Sunbird would be affected.
Comment 4•11 years ago
|
||
Comment on attachment 694289 [details] [diff] [review] Change Services.appshell to Services.appShell r=philipp
Attachment #694289 -
Flags: review?(philipp) → review+
Flags: needinfo?(philipp)
Assignee | ||
Comment 5•11 years ago
|
||
Assignee | ||
Comment 6•11 years ago
|
||
Fallen: Should this be ported to the branches?
Keywords: checkin-needed
Whiteboard: [leave open for porting to branches]
Assignee | ||
Updated•11 years ago
|
Attachment #694289 -
Attachment is obsolete: true
Comment 7•11 years ago
|
||
Comment on attachment 698773 [details] [diff] [review] Change Services.appshell to Services.appShell, r=philipp Sure, go ahead!
Attachment #698773 -
Flags: approval-calendar-beta+
Attachment #698773 -
Flags: approval-calendar-aurora+
Comment 8•11 years ago
|
||
(Its not really worth the effort to port to branches since its in Sunbird only, but it won't hurt)
Comment 9•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/a5ea04a91cec
Keywords: checkin-needed
Comment 10•11 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/d65d5df382af https://hg.mozilla.org/releases/comm-beta/rev/db200194fee4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [leave open for porting to branches]
Target Milestone: --- → 2.0
Updated•11 years ago
|
Target Milestone: 2.0 → 2.1
You need to log in
before you can comment on or make changes to this bug.
Description
•