823498 - Missing Message-ID header in invitation email

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[Jan Hejl]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:17.0) Gecko/20100101 Firefox/17.0
Build ID: 20121129165506

Steps to reproduce:

Create invitation with users to be notified


Actual results:

Invitation email is missing Message-ID header


Expected results:

Invitation message should have Message-ID header.

Comment 1

[[:MakeMyDay]]

Confirming this is still an issue on current trunk.

When this get's fixed, one should consider to also add further headers as specified in the setting for the respective mail account (e.g. organization, reply-to address, returnReceipt, etc.). Adding a priority header set to the value of the vevent priority is also worth to think of. Last but not least setting a User-Agent header (prob. extend by the application name and version of Lightning) might make bug analysis little easier if related to imip/itip bugs.

The account related stuff mentioned above should also be considered to be added for mails composed for all/undecided attendees out of the event dialog.

Comment 2

[[:MakeMyDay]]

Attachment: ImprovedMessageHeaderSupport-V1.diff

This patch adds the message-id to invitation mails and adds also organizer and sender's CN (based on the identity) to the mail headers of the same.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8567635 [details] [diff] [review]
ImprovedMessageHeaderSupport-V1.diff

Review of attachment 8567635 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/itip/calItipEmailTransport.js
@@ +304,5 @@
>                                                               "UTF-8",
>                                                               fieldNameLen,
>                                                               Components.interfaces.nsIMimeConverter.MIME_ENCODED_WORD_SIZE);
>              }
> +            

Added some whitespaces here.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 11bbc7e7b180

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

There is a whitespace missing at https://hg.mozilla.org/comm-central/rev/11bbc7e7b180#l1.65
> cal.validateRecipientList(aIdentity.fullName + "<" + aIdentity.email + ">");

Comment 6

[[:MakeMyDay]]

Thanks for finding this. I will do a correction.

Comment 7

[[:MakeMyDay]]

Attachment: ImprovedMessageHeaderSupport-RegressionFix-V1.diff

Regression Fix, applying on top of the already checked in patch.

Beside the correction Archaeopteryx mentioned, I removed the User-Agent header, since bug 1037978 is not yet checked in.

Comment 8

[[:MakeMyDay]]

Regression fix pushed to cc: https://hg.mozilla.org/comm-central/rev/2717b1d486cf

It still needs to be pushed to Aurora.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://hg.mozilla.org/releases/comm-aurora/rev/a776bf569c09