Closed
Bug 823540
Opened 12 years ago
Closed 12 years ago
use absolute URLs for the shared resources in the Camera app
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect, P2)
Tracking
(blocking-basecamp:+)
People
(Reporter: kaze, Assigned: kaze)
References
Details
Attachments
(1 file)
The Camera app (apps/camera) is copied at build time into the System app (apps/system/camera). As the shared resources in the Camera are using relative paths, we currently rely on a dirty hack in the Makefile to add “../” with a |sed -e| call. This is ugly and not necessary: using "/shared" would always work, regardless of the position of the HTML file in the file structure. This blocks bug 821691.
|
Assignee | |
Comment 1•12 years ago
|
||
This bug should be considered BB+ as it blocks a BB+ item.
Assignee: nobody → kaze
Attachment #694392 -
Flags: review?(poirot.alex)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 694392 [details]
patch proposal
Looks good, I'd even dream to do that on the whole codebase :o
Tested camera by taking pictures and deleting them, works fine.
Attachment #694392 -
Flags: review?(poirot.alex) → review+
|
||
Updated•12 years ago
|
blocking-basecamp: --- → +
Priority: -- → P2
Target Milestone: --- → B2G C3 (12dec-1jan)
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/dca559b891d7593a4e9f99b7d484cacfb26d55be
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 4•11 years ago
|
||
Confirmed changes as well as camera functionality. Verified build 20130110070201.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•