Closed
Bug 823589
Opened 12 years ago
Closed 12 years ago
Lots of struct/class warnings in MSVC caused by ForwardDeclare macros
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 823080
People
(Reporter: dmandelin, Unassigned)
Details
The ForwardDeclare macros always use |class|, but many of those types are declared with |struct|, so MSVC generates tons of warnings. This is annoying. Maybe we should just change those structs to classes now? They are much more class-like anyway.
Comment 1•12 years ago
|
||
We could, certainly. If any of these are JSAPI-visible, that'll require embedders to make the same change to avoid warnings. I think we want to make the change eventually, so maybe we just bite the bullet and do it. Although, to be perfectly honest, the ForwardDeclare* macros look truly awful to me, and I wonder if there's not some better way to do this that avoids this madness entirely.
Reporter | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•