Closed
Bug 823745
Opened 11 years ago
Closed 11 years ago
If we don't have support/homepage links, we should align the buttons better
Categories
(Marketplace Graveyard :: Consumer Pages, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
2013-05-30
People
(Reporter: krupa.mozbugs, Assigned: msandberg)
References
()
Details
Attachments
(1 file)
68.41 KB,
image/png
|
Details |
steps to reproduce: 1. Load https://marketplace-dev.allizom.org/app/calculator/?src=mkt-home 2. Notice the Privacy Policy and Report abuse link expected behavior: If support/homepage links are missing, the buttons are spread out and follow the visual columns created by the Reviews section. observed behavior: Bother buttons are bundled up on one side.
Comment 1•11 years ago
|
||
Putting them in separate wide columns isn't going to make them look better. Centering might help. -> wontfix, but I'll CC mushi on it in case she wants to change them.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Reporter | ||
Comment 2•11 years ago
|
||
Let's have UX pitch in before closing a bug as WONTFIX. Many people filter by open bugs when reviewing bugs in their queue.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Updated•11 years ago
|
Assignee: nobody → msandberg
Comment 3•11 years ago
|
||
This is an issue when there are 3 buttons too. My vote would be to center them but I'm cc'ing Michael Maslaney who should have the final call from a visual design point of view.
Comment 4•11 years ago
|
||
I agree with you, Maureen. Let's center align the button three buttons.
Comment 5•11 years ago
|
||
cvan: stuart: either of you want to nab this? Seems like it's just displaying those buttons inline-block and text-align:center for desktop.
Comment 6•11 years ago
|
||
Can we close this? I think this looks fine.
Comment 7•11 years ago
|
||
close based on comment 6
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → 2013-05-30
Reporter | ||
Comment 8•11 years ago
|
||
This wasn't fixed. Cvan just wontfixed it. Is UX cool with that?
Reporter | ||
Updated•11 years ago
|
Flags: needinfo?(mmaslaney)
Comment 9•11 years ago
|
||
This looks completely fine to me: http://f.cl.ly/items/0f0n1V10382a3z1e3D10/Screen%20Shot%202013-05-30%20at%2010.02.54%20AM.png Centering any buttons totally throws off the grid, and doesn't look better at all: http://f.cl.ly/items/402s2s1E06400u3A1r0Q/Screen%20Shot%202013-05-30%20at%2010.08.32%20AM.png Alternatively, we could stretch the buttons out proportionally so the last one is flush right with the container: http://f.cl.ly/items/0u212o3V0Y121Z404403/Screen%20Shot%202013-05-30%20at%2010.05.29%20AM.png I'm WONTFIXing this based on RESOLVED LOOKSGOODTOME :) I'll gladly reopen if Michael has input here.
Resolution: FIXED → WONTFIX
Comment 10•11 years ago
|
||
Most elements are flush left, so option one is fine with me. Alternatively, the third option would probably look best if the dev team has the bandwidth to implement.
Flags: needinfo?(mmaslaney)
You need to log in
before you can comment on or make changes to this bug.
Description
•