82436 - assertion needed in PR_Lock

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Kathleen :Brade]

I was running the mozilla client on NT earlier today and ran into a problem when 
I crashed in PR_Lock because it had been passed a null lock as its parameter.

I think that PR_Lock should assert when it is passed a null lock (rather than 
crashing later (PR_ASSERT(lock->owner != me);) when lock is dereferenced.

This could be fixed by changing the above assertion(s) to something like:
  PR_ASSERT(lock && lock->owner != me);
or by adding a new line near the top (something like):
  PR_ASSERT(lock);

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch.

Comment 2

[Wan-Teh Chang]

Fixed on the trunk of NSPR.  I assert that lock is not NULL
in PR_Unlock as well.

Mozilla client won't pick up this change until it switches
to NSPR 4.2.