824751 - Do not try to make a bango number premium twice (payment registration)

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[Kumar McMillan [:kumar]]

STR:
1. Upload an app and enable payments
2. Associate the app with an account and save
3. Go back to the same screen and click save a second time on that app

The code is trying to call the make-premium Bango API on a number that is already premium. This is unnecessary and results in an error like:

s.client:ERROR Solitude error with https://payments-dev.allizom.org/bango/premium/: u'{"error_code": "<type \'type\'>", "error_data": {}, "error_message": "<type \'type\'>: The specified Bango Number is already enabled for premium billing"}' :/data/www/addons-dev.allizom.org/zamboni/lib/pay_server/base.py:126

The devhub screen says: We encountered a problem connecting to the payment server.

Comment 1

[krupa raj[:krupa]]

Note that this also blocks users from doing any changes to their price tier/currency or bank account selection.

Comment 2

[Andy McKay]

Premium doesn't change anything in the solitude database, because it doesn't return any new data. I would if we should record that it did run successfully.

Comment 3

[Kumar McMillan [:kumar]]

Thanks Andy. This is working for me now.

https://github.com/mozilla/solitude/commit/854187f13e6b4fc01332646dda25607a58f96d12