824957 - verify format of desktop releases' changesets file

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[[e-mail] (:bhearsum)]

We do this for the mobile JSON changesets, but don't have a similar check for Firefox

Comment 1

[[e-mail] (:bhearsum)]

Attachment: separate plain text changesets parsing into a function

With tests!

Comment 2

[[e-mail] (:bhearsum)]

Attachment: verify changesets upon submission

Comment 3

[[e-mail] (:bhearsum)]

Landed in http://git.mozilla.org/?p=build/release-kickoff.git;a=commit;h=2f372f772acf6737691b96502fb797fdc8584bd3.

Comment 4

[Pete Moore [:pmoore][:pete]]

Comment on attachment 696337 [details] [diff] [review]
separate plain text changesets parsing into a function

Review of attachment 696337 [details] [diff] [review]:
-----------------------------------------------------------------

Just found a (very small) bug in this patch...

Pete

::: lib/python/release/l10n.py
@@ +61,3 @@
>              if revision == 'FIXME':
>                  raise Exception('Found FIXME in %s for locale "%s"' % \
>                                  (fileName, locale))

The variable "fileName" (above) no longer exists, because the function definition changed from:

getL10nRepositories(fileName, l10nRepoPath, relbranch=None)
to
getL10nRepositories(changesets, l10nRepoPath, relbranch=None)

Comment 5

[Pete Moore [:pmoore][:pete]]

Opened bug 937175 for this issue instead.