825121 - [Lockscreen] service provider shown wrongly when roaming

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect, P3)

Description

[Walter Chen[:ypwalter][:wachen]]

According to tw gaia team members' feedback. The lock-screen should should the roaming call/data services provider. It should not show the original service provider.

For example, if you have a China Mobile card, when you are roaming in Taiwan Mobile, it should show Taiwan Mobile, and vice versa.

Comment 1

[Walter Chen[:ypwalter][:wachen]]

2012-12-27 date build from pvt server

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+, P3, C4 - severe usability issue

Comment 3

[Etienne Segonzac (:etienne)]

Is it still happening now that we are using the MobileOperator helper everywhere in the system app?

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

is this related to bug 825123?

Comment 5

[Walter Chen[:ypwalter][:wachen]]

It's not related.

This one is just about showing wrong service provider's name everywhere.
Nothing affecting functionality

bug 825123 is about it can't get the current/previous service provider's network settings, and it will not have data roaming in this case. It's not the same root cause, and this one is affecting the real functionality of using data roaming.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Etienne, this bug occurred with China Mobile sim card, I will verify it with AT&T.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

below is result:
===============
AT&T (correct)
  network.longName: Taiwan Mobile Co. Ltd
  network.shortName: Taiwan Mobile
  iccInfo.spn: null
  iccInfo.isDisplaySpnRequired: false
  iccInfo.isDisplayNetworkNameRequired: true

China Mobile (incorrect)
  network.longName: Taiwan Mobile Co. Ltd
  network.shortName: Taiwan Mobile
  iccInfo.spn: -�5
  iccInfo.isDisplaySpnRequired: true
  iccInfo.isDisplayNetworkNameRequired: false

per talked with Gecko member Patrick, isDisplaySpnRequired value comes from sim card.

Is looks like a sim card issue.

Joe, Do you have contact window of Telefonica who can confirm the right behaviour?

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

Hi Daniel, do you think you can provide more information on comment 7? what's the target market SIM should behave like? Thanks 

and QAWANTED for confirmation on the roaming behavior using target market SIMs.

Comment 9

[Walter Chen[:ypwalter][:wachen]]

(In reply to Joe Cheng [:jcheng] from comment #8)
> and QAWANTED for confirmation on the roaming behavior using target market
> SIMs.

Joe, is it possible for us to get a targeted market sim card?

Comment 10

[Daniel Coloma:dcoloma]

I think that whenever you are roaming, the service provider name should be the one of the operator is providing you the service in the roaming country, regardless the values of the ICC flags. 

Adding dpv to the loop to double check.

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I will implement according Daniel comment Tuesday if no addition comments coming.

Comment 12

[Anthony Ricaud (:rik)]

I can reproduce here in Berlin with a Telenor SIM card.

shortName:  Vodafone
longName:  Vodafone D2 GmbH
isDisplaySpnRequired:  true
isDisplayNetworkNameRequired:  false
spn:  TELENOR

It should display Vodafone (or maybe Vodafone D2 GmbH) but it displays TELENOR.

Comment 13

[Walter Chen[:ypwalter][:wachen]]

Cool, that means more SIM cards have the same issue. In that case, developers should better handling similiar situation so that it can be solved!

Comment 14

[Anthony Ricaud (:rik)]

Stealing this from Yuren.

I have a patch on my branch https://github.com/Rik/gaia/tree/roaming-825121 but I'm waiting to check with Telefonica people if it's the right behaviour.

Comment 16

[David Palomino [:dpalomino]]

Hi, 

Beatriz and I have been discussing about this issue. We think the carrier name shown in the lock screen should always be the roaming network the device is attached to. 

Thanks!
David

Comment 17

[Anthony Ricaud (:rik)]

Attachment: Review pointer to https://github.com/mozilla-b2g/gaia/pull/7414

Thanks David and Beatriz. Here's the patch then.

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/commit/8869378ddac902b09fc6d4838b29f2af36381438

Comment 19

[Walter Chen[:ypwalter][:wachen]]

Verified Fixed

Device: Unagi
Build Identifier: 20130113070202
Update channel: 
   nightly b2g18 (pvt server)  
   unagi.zip	13-Jan-2013 08:06 	100M	 
   https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi-eng/
Git commit info: 2013-11-13 15:15:51

Comment 20

[Lukas Blakk [:lsblakk] use ?needinfo]

Given that this landed prior to the 1/25 branching for v1.0 we are marking this fixed in v1.0.1 as well.