825125 - "Seek" buttons don't reflect seeking state

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

If you press a seek button in the radio app, there's a pretty subtle dancing-dots indicator under the station name that's easy to miss.  At least, I missed it for a while.

Seeking the radio can take a while, so only a few pixels in the UI will change in that time.  If the user misses the indicator, they might think that the radio is wedged and go into USER-SMASH-BUTTONS mode.  At least, I did.

So it might be a good idea to make the seek indicator less subtle, or disable the seek buttons while the operation completes in the radio hw.

bb? to get on radar.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB-, tracking-b2g18+

Comment 2

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Is someone working on this bug?

I am looking to take it, but first, can I get more details on the intended behavior: should the seek buttons be disabled while seeking? or should the "dancing-dots" be enlarged to make them less subtle?

Comment 3

[Josh Carpenter [:jcarpenter]]

Thanks Mihai, I'll discuss with the UX team today in London and we'll follow up.

Comment 4

[Josh Carpenter [:jcarpenter]]

We may be able to reuse the visual design being implemented in bug #853742 for this as well.

Comment 5

[Josh Carpenter [:jcarpenter]]

Casey, I seem to recall that you worked on this with the dev team?

Comment 6

[Casey Yee]

I agree that there needs to be a more obvious way to show that the radio is seeking a station.

Using something a little more obvious than the ". . ." would make sense.    As suggested in Comment 4, we could re-use the spinner in bug #853742.

Patryk, and thoughts?

Comment 7

[Patryk Adamczyk [:patryk] UX]

The solution in bug #853742 (spinner) should be used here.

Comment 8

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks Patryk, I will wait for the patch for Bug 853742 (which hopefully adds the spinner, as detailed in the posted mockups) before working on this bug.

Comment 9

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #9346 - Change seeking state UI to use spinners

Use the spinner introduced in Bug 853742 to reflect the seeking state:
* seek-up: rotates the spinner in clockwise direction
* seek-down: rotates the spinner in counter-clockwise direction

Comment 10

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Patryk, is the behavior highlighted in comment 9 (i.e. spinner rotation determined by seeking direction) the desired one for reflecting the seeking state?

Comment 11

[Patryk Adamczyk [:patryk] UX]

The direction should be clockwise only. 

Its a shame we have delay, ideally with better hardware this will go away, I really hope the user doesn't need to wait so long that he has to ponder whether he pressed the right "seek" direction.

Comment 12

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to Patryk Adamczyk [:patryk] UX from comment #11)
> The direction should be clockwise only. 
> 
> Its a shame we have delay, ideally with better hardware this will go away, I
> really hope the user doesn't need to wait so long that he has to ponder
> whether he pressed the right "seek" direction.

Thanks for the feedback, Patryk, I updated the patch accordingly. Now, regardless of which seek direction button is pressed, the spinner rotates only clockwise.

Tim, feel free to look over the patch whenever you have the time, thanks!

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 740435 [details]
Pull Request #9346 - Change seeking state UI to use spinners

There are two CSS questions that I don't know why you write it this way.

Overall it looks good though.

Comment 14

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 740435 [details]
Pull Request #9346 - Change seeking state UI to use spinners

Thanks for the comments, Tim! I replied on GitHub and updated the pull request. Feel free to merge it if it looks good now.

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 740435 [details]
Pull Request #9346 - Change seeking state UI to use spinners

https://github.com/mozilla-b2g/gaia/pull/9346#r3954901

Fix that and you are good to go :) Thanks!

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/commit/b25371c8d65bb8199cd59901d79df75771762b27

Comment 17

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 740435 [details]
Pull Request #9346 - Change seeking state UI to use spinners

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): FM Radio > seeking
User impact if declined: Low (seeking state might not be noticeable to the user)
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): Low/None (depending patch for bug 853742 is already uplifted to v1-train)
String or UUID changes made by this patch: No

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted b25371c8d65bb8199cd59901d79df75771762b27 to:
v1-train: 7c3d9954c998a566564d9e83d0c3441a83924f40

Comment 19

[Askeing Yen[:askeing][:fyen]]

Unagi
Gaia:     186d31782d8cadb296661a7d104bc28846d1dfb9
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/66334a3bddcb
BuildID   20130508070204
Version   18.0

Verified base on comment 11.