825322 - fix preseed image with proper boot args

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, task)

Description

[Jake Watkins [:dividehex]]

The preseed image is missing some boot args and there is some unnecessary logic in there.

Comment 1

[Jake Watkins [:dividehex]]

Attachment: Fixed missing args and removed if else

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 696396 [details] [diff] [review]
Fixed missing args and removed if else

Review of attachment 696396 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not entirely qualified to judge that, but it certainly looks reasonable to me.

How will we go about fixing this on the existing cards?  Should we make a "pre-seed" pxe_config, script, and image?

Comment 3

[Jake Watkins [:dividehex]]

I also added a usb stop statement.  This might help with the kernel not initializing the usb properly once in awhile which is probably from a dirty init state made by uboot putting its hands on the usb bus before its handed to the kernel.

Comment 4

[Jake Watkins [:dividehex]]

(In reply to Dustin J. Mitchell [:dustin] from comment #2)

> How will we go about fixing this on the existing cards?  Should we make a
> "pre-seed" pxe_config, script, and image?

This will depend on the outcome of 819545 and if we end up needing to alter the partition table.  If part table doesn't need changing, then yes, we can script this into a mozpool pxe_config and image.

Comment 5

[Jake Watkins [:dividehex]]

I have pushed a new preseed image to the puppetagain puppet masters with the fixed boot.scr.

It can be accessed here: http://puppetagain.pub.build.mozilla.org/data/bmm/preseed/uboot-preseed.2013010200.img.bz2

Comment 6

[Jake Watkins [:dividehex]]

The last preseed contained a minor flaw. Use this preseed instead: http://puppetagain.pub.build.mozilla.org/data/bmm/preseed/uboot-preseed.2013010300.img.bz2