825399 - Download large images ( > 5MB) to disk when setting wallpaper from context menu

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Sriram [:sriramr]]

This is a follow up for bug 715736. 

https://bugzilla.mozilla.org/show_bug.cgi?id=715736#c44

Currently the wallpaper is set by converting the image into a ByteArray for scaling purposes. Converting large images into a ByteArray can cause an OutOfMemoryException and thus result in failure of setting wallpaper. 

Thus, by downloading large images ( > 5MB) to disk we can sample the image and scale it down without running out of memory.

Comment 1

[Erica Hansen]

Hi my partner and I are interested in fixing this bug. Can we get assigned to it? Is there any chance we could get a mentor for this, since this would be our first bug fix?

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Erica Hansen from comment #1)
> Hi my partner and I are interested in fixing this bug. Can we get assigned
> to it? Is there any chance we could get a mentor for this, since this would
> be our first bug fix?

Yup, I can mentor you no problem.

Comment 3

[Wesley Johnston (:wesj)]

The patch in bug 901824 would also handle this, but is frozen :(

Comment 4

[Tim Stullich [:tstullich]]

Is this bug still open to be taken? It seems like there was someone already assigned to the problem, so if someone is already working on this I won't intrude. Otherwise, I would gladly work on this.

Comment 5

[Erica Hansen]

I haven't had much time to work on this. So feel free to take it up.
(In reply to Tim Stullich from comment #4)
> Is this bug still open to be taken? It seems like there was someone already
> assigned to the problem, so if someone is already working on this I won't
> intrude. Otherwise, I would gladly work on this.

Comment 6

[Tim Stullich [:tstullich]]

Sounds good. If possible could I be added as the assignee for this bug?

Comment 7

[Tim Stullich [:tstullich]]

Also, what progress has been made on fixing this issue? Erika, perhaps you might be able to tell me.

Comment 8

[Tim Stullich [:tstullich]]

The way things are set up right now is that when a large image is being downloaded there is no visual feedback being given to the user that a download is being performed, which I think should be changed. The application simply sits there while the image is being downloaded, which gives the impression to the user that nothing is happening. What would be a good way to handle this problem?

Comment 9

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.