825449 - Filter editor: Accesskey for 'Perform these actions' should set/move focus to first action item (at the moment invisible/not shown)

Status: RESOLVED FIXED

(MailNews Core :: Filters, enhancement)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thunderbird Earlybird 19.0a2 20121229

At the moment, the filter editor for creating/editing a filter has the box 'Perform these actions' with access key 'P'. Pressing this access key will move it to the label, there is no focus shown and nothing can be done there, so it should be set to the first action item in that box.

Comment 1

[:aceman]

You mean focus the first action menulist?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Yes (at least something with a focus ring indicator).

Comment 3

[:aceman]

Attachment: patch

Ok, here you go.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 698342 [details] [diff] [review]
patch

Thank you, your fix works like I imagined.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 698342 [details] [diff] [review]
patch

Okay so ui-r=me if (and this is a big if!), when you've selected item 3, and focus another element, and then re-focus the list, item 3 is still the focused one.  (Does that make sense?  I can't seem to compile, so I'm sort of going by inspection here…)

Thanks,
Blake.

Comment 6

[:aceman]

Attachment: patch v2

Ok, if you think so.

Comment 7

[Kent James (:rkent)]

Comment on attachment 715232 [details] [diff] [review]
patch v2

Looks fine to me. Thanks for the patch!

Comment 8

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 715232 [details] [diff] [review]
patch v2

Seems good.  ui-r=me.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/525b199453d9