825692 - Avoid mShouldBuildLayer for textboxes on B2G

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

"ShouldBuildLayer case should check mVScrollbarBox and mHScrollbarBox for null as well as styles.mHorizontal/mVertical for HIDDEN"

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Avoid layerizing scrollframes that don't have scrollbar boxes

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 696809 [details] [diff] [review]
Avoid layerizing scrollframes that don't have scrollbar boxes

Review of attachment 696809 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsGfxScrollFrame.cpp
@@ +2088,5 @@
>      ScrollbarStyles styles = GetScrollbarStylesFromFrame();
>      mShouldBuildLayer =
>         (styles.mHorizontal != NS_STYLE_OVERFLOW_HIDDEN ||
>          styles.mVertical != NS_STYLE_OVERFLOW_HIDDEN) &&
> +       (mVScrollbarBox || mHScrollbarBox) &&

Actually I think we should check styles.mHorizontal != HIDDEN && mHScrollbarBox etc. We need to have at least one scrollbar that's both present and has style != HIDDEN.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Avoid layerizing scrollframes that don't have scrollbar boxes v2

I'm happy with the stricter condition.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1004c01bb817

This fixes an unnecessary performance problem with input boxes and only impacts B2G

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1004c01bb817

Comment 6

[Andrew Overholt [:overholt]]

Does this need to be uplifted?

Comment 7

[Jeff Muizelaar [:jrmuizel]]

(In reply to Andrew Overholt [:overholt] from comment #6)
> Does this need to be uplifted?

Yes.

Comment 8

[Alex Keybl [:akeybl]]

Ryan - would you mind helping here?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b07bf54151d1
https://hg.mozilla.org/releases/mozilla-b2g18/rev/e6edce84651f