826085 - [B2G] [SMS] Contacts : SMS message deleted when choosing contact for search or contact list

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Description

[Misty Byrd]

Attachment: enter into message field before choosing contact

Perquisites:
1. Import fake contacts from UI tests
2. Add a new  contact

Steps to Reproduce: Previously typed message is deleted from text field when choosing a contact from search or contacts icon.

Steps to Reproduce:
1) Install Build 20130102070202 v.1 on an Unagi Device
2) Select SMS app
3.) Select + to open new SMS
4) Type Message in message field
5)  Type existing contact in search field/or select contact icon
6) Select a valid contact from the existing list 

Expected:
Contact added to field can send message
Repro frequency:
Repros 10/10 times

Actual:
When selecting an existing contact the message field that a previously typed message is deleted. Must retype message after selecting contact

Comment 1

[Misty Byrd]

Attachment: screen shot step 2

Comment 2

[Misty Byrd]

Attachment: step 3

Comment 3

[Josh Carpenter [:jcarpenter]]

Yikes, should definitely fix this. Adding "BerlinWW" for dev attention this week.

Comment 4

[Borja Salguero [:borjasalguero]]

Ok, I will come back with a patch!

Comment 5

[Borja Salguero [:borjasalguero]]

I've never realized of this issue, but it's horrible! We should update to BB+ because the user interaction it's so bad without the patch.

Comment 6

[Borja Salguero [:borjasalguero]]

Attachment: PR

Comment 7

[Borja Salguero [:borjasalguero]]

Patch ready!

Comment 8

[Borja Salguero [:borjasalguero]]

Im gonna include some comments of Ayman, so the patch will be ready asap!

Comment 9

[Borja Salguero [:borjasalguero]]

Only thing to fix to the patch is the sentence that we are going to show to the user (i.e. 'Are you sure you want to discard this SMS?). Ayman, what will be the right one? Thanks!

Comment 10

[ayman maat :maat]

(In reply to Borja Salguero [:borjasalguero] from comment #9)
> Only thing to fix to the patch is the sentence that we are going to show to
> the user (i.e. 'Are you sure you want to discard this SMS?). Ayman, what
> will be the right one? Thanks!

**text** 
are you sure you want to discard this message?

**2 CTAs** 
yes | no

Comment 11

[Steve Chung [:steveck]]

Comment on attachment 699284 [details]
PR

Hi Borja, I've leave some comments on github. You can ask for the review again when you complete the fixing. Thanks.

Comment 12

[Borja Salguero [:borjasalguero]]

Comment on attachment 699284 [details]
PR

Im gonna add Kaze to l10n review as well.

Comment 13

[Fabien Cazenave [:kaze]]

Comment on attachment 699284 [details]
PR

r=me for the l10n part

Comment 14

[Delphine Lebédel [:delphine - Use needinfo]]

Verified fixed in 2013-01-25-07-02-01 pvt nightly b2g18 build