Closed
Bug 826120
Opened 11 years ago
Closed 11 years ago
mach's warning parser is confused by some gcc 4.6 warning messages containing '[' chars
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox19 wontfix, firefox20 fixed)
RESOLVED
FIXED
mozilla20
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
Attachments
(1 file)
|
2.05 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
When parsing "warning: (near initialization for 'full_wmonthname[0]') [-Wpointer-sign]", mach thinks the warning name is "0" instead of "-Wpointer-sign". I added a test case to test_warnings.py, but I couldn't find any instructions on how to actually run the mach unit tests. <:)
Attachment #697268 -
Flags: review?(gps)
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
|
||
Comment 1•11 years ago
|
||
Comment on attachment 697268 [details] [diff] [review] mach-warnings.patch Review of attachment 697268 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #697268 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0ecff0cf5ee
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e0ecff0cf5ee
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•