826409 - Remove onBeforeDeleteURI and onBeforeItemRemoved notifications

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

These notifications were added originally to allow Sync to collect information before a place is gone, but currently all of the information is provided already in onDeleteURI and onItemRemoved, so the Before notifications may likely go.

Though, the actual reason for the removal is that with off main-thread removals they complicate things too much, since we must collect places to remove off main-thread, notify onBefore on main-thread, proceed with removal off main-thread, notify removal on main-thread.
This adds lot of complication to properly synchronize all of the runnables, once we enter the "other" thread, we'd like to stay there until we're done.

We should verify if Sync and Places code can live without onBefore notifications, deprecate them, and finally remove them.

Comment 1

[Richard Newman [:rnewman]]

This is ready for you, mak!

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1.0

it's a big patch, but basically just removals.

I'm now going to file a bug for Seamonkey, but it's not blocking since even if js consumers have these methods defined nothing bad happens.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 710373 [details] [diff] [review]
patch v1.0

This one was easy.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 710373 [details] [diff] [review]
patch v1.0

Asking SR for the removal of the 2 notifications

Comment 5

[:Gavin Sharp [email: [e-mail]]]

CCing some of the authors of the potentially affected authors I could find:

https://mxr.mozilla.org/addons/source/242697/chrome/content/main.js#233
(https://addons.mozilla.org/en-US/firefox/addon/viewmarks/)
https://mxr.mozilla.org/addons/source/410818/chrome/content/bookmarks.js#21
(https://addons.mozilla.org/en-US/firefox/addon/booky/)
https://mxr.mozilla.org/addons/source/399944/chrome/content/browserOverlay.js#457
(https://addons.mozilla.org/en-US/firefox/addon/boom/)
https://mxr.mozilla.org/addons/source/392659/chrome/content/sortBookmarks.js#135
(https://addons.mozilla.org/en-US/firefox/addon/auto-sort-bookmarks/)
https://mxr.mozilla.org/addons/source/363782/chrome/content/tabdock-bookmarks.js#26
(https://addons.mozilla.org/en-US/firefox/addon/fdock/)
https://mxr.mozilla.org/addons/source/2499/modules/liveplaces.jsm#1375
(https://addons.mozilla.org/en-US/firefox/addon/liveclick/)
https://mxr.mozilla.org/addons/source/4578/modules/Storage.jsm#1496
(https://addons.mozilla.org/en-US/firefox/addon/brief/)
https://mxr.mozilla.org/addons/source/9071/chrome/content/sync/log.js#168
(https://addons.mozilla.org/en-US/firefox/addon/categorize/)

Comment 6

[Marco Bonardo [:mak]]

Thanks, this has also been notified through mozilla.dev.extensions, on planet firefox and planet mozilla.
I also brefly discussed (right now) with TheOne who had an add-on using this notification and looks like he doesn't really need it, onItemRemoved covers most cases we thought about.

Comment 7

[Marco Bonardo [:mak]]

for authors, notice onItemRemoved you get the parentId, this is valid and you can use it without any problem (items are notified before their containing folders), for example to check if an item is a tag.
onItemRemoved has also many new information compared to what it was when the Before version was introduced.

Comment 8

[Marco Bonardo [:mak]]

fixed a minor typo in test_placesTxn and landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e913428a6628

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e913428a6628