826739 - when usb is mounted, Device Storage subtitle says "{[ plural(size) ]}"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Dietrich Ayala (:dietrich)]

Reproducible:

* Connect phone to computer via USB cable
* Open Settings/Media storage
* Click USB mass storage enabl...
* Click the back button

Expected: Device storage subtitle shows the space available

Actual: Device storage subtitle shows "{[ plural(size) ]}"

Comment 1

[Daniel Holbert [:dholbert]]

This persists after you disconnect your device from USB, too - it stays broken until you move to another settings screen & back.  (or quit and reopen settings)

Also: When the USB storage is mounted, if you tap "Device Storage" to dig into more details, it says:
  Total Space   NaN B
  Used          undefined
  Left          undefined

Requesting blocking, as this looks pretty broken.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of "{[ plural(size) ]}", just after I've unmounted USB storage

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot of Device Storage settings page, w/ NaN & undefined

Comment 4

[Dietrich Ayala (:dietrich)]

Sad that so broken, but not holding release on it. Would really like to take a fix on approval for this. HINT HINT.

Comment 5

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 6

[Fabien Cazenave [:kaze]]

https://github.com/mozilla-b2g/gaia/pull/7573

Comment 7

[Evelyn Hung]

Comment on attachment 701116 [details]
patch proposal

r=me, look great. Thanks!

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/d7ce771172143cec336def2b2beabcd848c3a4d1

Comment 9

[Delphine Lebédel [:delphine - Use needinfo]]

Verified fixed in 2013-01-24-14-08-59 pvt nightly b2g18 build