826916 - Keyboard loses focus when changing data unit in setup

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Go through setup
 (2) On "Data usage limit" screen, tap "GB" selector

The keyboard loses focus, but I don't want it to lose focus.

bb? -> radar

NOT A REGRESSION FROM BUG 823619

Comment 1

[Dietrich Ayala (:dietrich)]

Has workaround, not blocking. Marking tracking+ for 1.0 fix.

Comment 2

[Salvador de la Puente González [:salva]]

This is a little bit tricky. It depends on bug #687787 but I'm trying to use `blur` instead but I don't get to stop loosing the focus.

  dataLimitInput.addEventListener('blur',
    function _preventFocusLost(evt) {
      evt.preventDefault();
    }
  );

Can you help me Chris?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

blur happens after the target has lost focus, so preventDefault doesn't make sense.
(bug 687787 is way too risky for b2g-18)

Comment 4

[Salvador de la Puente González [:salva]]

Ok, so I need some event before loosing the focus. If not, I can recover the focus after pressing the button but the result is quite ugly: it looses the focus, the keyboard disappears, then it recovers the focus and the keyboard appears again.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

You'll want to follow the SMS app's example

https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/sms.js#L705

preventDefault()ing the mousedown on the button seems to do the trick for SMS.

Comment 6

[Salvador de la Puente González [:salva]]

Attachment: Prevent input lost of focus when switching the Unit

Comment 7

[Salvador de la Puente González [:salva]]

Comment on attachment 705764 [details]
Prevent input lost of focus when switching the Unit

Bug caused by (feature/regressing bug #): this one
User impact if declined: medium
Testing completed: yes
Risk to taking this patch (and alternatives if risky): very low

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 705764 [details]
Prevent input lost of focus when switching the Unit

Pretty simple change r=me

Thanks for keeping it clean Salva ;)

Comment 9

[Salvador de la Puente González [:salva]]

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/197db965f817daf46189bc9b29b8a472f6224257

Comment 10

[Carlos Martínez Toral [:carlosmartinez]]

Working fine in Gecko-cfad7c9.Gaia-6c53dfd.