827214 - Actually convert HTML lists to WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Bug 824823 didn't quite manage to convert HTML lists to WebIDL.  We added the classes and so forth... but we didn't start creating instances of those objects!

Fixing that makes the firstChild test on Dromaeo faster, but lastChild is still being slow for some reason.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix HTML lists to really be webidl.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Boris Zbarsky (:bz) from comment #0)
> Fixing that makes the firstChild test on Dromaeo faster, but lastChild is
> still being slow for some reason.

Possibly related: GetLastChild calls GetChildArray, which is virtual.
http://mxr.mozilla.org/mozilla-central/source/content/base/public/nsINode.h#1034

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 698548 [details] [diff] [review]
Fix HTML lists to really be webidl.

Review of attachment 698548 [details] [diff] [review]:
-----------------------------------------------------------------

Hah.

Comment 4

[Boris Zbarsky [:bzbarsky]]

> Possibly related: GetLastChild calls GetChildArray, which is virtual.

Oh!  I'd totally forgotten that.  We really need to finish that conversion.  :(  That might certainly explain part of what's going on there...  But also, we're going through genericGetter for some reason, which can't possibly help.  I still need to sort that out.

Try is green, so https://hg.mozilla.org/integration/mozilla-inbound/rev/557e0a6e3ca7

Comment 5

[Boris Zbarsky [:bzbarsky]]

Improvement: Mozilla-Inbound-Non-PGO - Dromaeo (DOM) - Win7 - 8.93% increase

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 698548 [details] [diff] [review]
Fix HTML lists to really be webidl.

Given bug 827516 we need this on Aurora 20, I think.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 824823
User impact if declined: Assertion failures and possible security issues.
Testing completed (on m-c, etc.): Passes tests.
Risk to taking this patch (and alternatives if risky): Very low risk, I think. 
   The other option is to fully turn off the WebIDL bindings for lists, which
   is doable if needed.
String or UUID changes made by this patch: None.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/557e0a6e3ca7

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/10e6c5983d6e

Comment 10

[Boris Zbarsky [:bzbarsky]]

I have verified that bug 827516 is also fixed on Aurora.