827321 - [Dialer] Can't call an emergency number when there is an existing contact with a phone number ends like the emergency number

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[David Scravaglieri [:scravag]]

STR

Goal: Trying to call the emergency phone number 112

1 - Create a fake contact with a phone number that ends with 112 (ie: [phone])
2 - Open Dialer type emergency phone call 112

Expected:
The emergency phone number 112 is called

Actual:
The Contact is called.

Comment 1

[Etienne Segonzac (:etienne)]

For anybody playing with this bug, *beware*:

You are actually calling *112* (the real one), the Dialer app doesn't show the right contact, but you are definitively calling the emergency number, so don't stay on the line :)

Comment 2

[Etienne Segonzac (:etienne)]

Attachment: Patch proposal - fixing the contact db tel searh indexes

Comment 3

[Etienne Segonzac (:etienne)]

Attachment: Patch proposal - fixing the contact db tel search indexes

Comment 4

[Gregor Wagner [:gwagner]]

Comment on attachment 698914 [details] [diff] [review]
Patch proposal - fixing the contact db tel search indexes

No that's not the right solution. Adding a new contact with the same number would result in the same situation.

Comment 5

[Etienne Segonzac (:etienne)]

(In reply to Gregor Wagner [:gwagner] from comment #4)
> Comment on attachment 698914 [details] [diff] [review]
> Patch proposal - fixing the contact db tel search indexes
> 
> No that's not the right solution. Adding a new contact with the same number
> would result in the same situation.

Adding a new contact didn't brought back the issue here...

Comment 6

[Etienne Segonzac (:etienne)]

Attachment: Patch v2

New version after talking with Gregor rebuilding just the right index.

Comment 7

[Etienne Segonzac (:etienne)]

Gregor pointer a new issue to me, adding a test right now...

Comment 8

[Etienne Segonzac (:etienne)]

Attachment: Patch v3

Brand new index, new test, DB migration (working wonderfully)... thanks for all the pointers Gregor!

Comment 9

[Gregor Wagner [:gwagner]]

Comment on attachment 699335 [details] [diff] [review]
Patch v3

Review of attachment 699335 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Ship it!
bent should check the upgrade code as well.

::: dom/contacts/fallback/ContactDB.jsm
@@ +55,5 @@
>  
>          // Properties indexes
>          objectStore.createIndex("nickname",   "properties.nickname",   { unique: false, multiEntry: true });
>          objectStore.createIndex("name",       "properties.name",       { unique: false, multiEntry: true });
> +        objectStore.createIndex("tel",        "search.exactTel",       { unique: false, multiEntry: true });

This shouldn't be needed. Please remove.

Comment 10

[Etienne Segonzac (:etienne)]

Attachment: Patch v4

Added the last comment and tested the SIM contact import, no problem.

Comment 11

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 699335 [details] [diff] [review]
Patch v3

Review of attachment 699335 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/contacts/fallback/ContactDB.jsm
@@ -59,3 @@
>          objectStore.createIndex("familyName", "properties.familyName", { unique: false, multiEntry: true });
>          objectStore.createIndex("givenName",  "properties.givenName",  { unique: false, multiEntry: true });
> -        objectStore.createIndex("tel",        "properties.tel",        { unique: false, multiEntry: true });

You should still delete this line here.

@@ +210,5 @@
> +
> +                  cursor.value.search.exactTel = [number];
> +                  if (parsedNumber &&
> +                      parsedNumber.internationalNumber &&
> +                      (number !== parsedNumber.internationalNumber)) {

Nit: These extra () aren't needed.

@@ +223,5 @@
> +          }
> +        };
> +
> +        // Delete old tel index (not on the right field).
> +        objectStore.deleteIndex("tel");

This might fail if this is the first time you're creating the database. Check |objectStore.indexNames.contains("tel")| before you do this deleteIndex.

@@ +226,5 @@
> +        // Delete old tel index (not on the right field).
> +        objectStore.deleteIndex("tel");
> +
> +        // Create new index for "equals" searches
> +        objectStore.createIndex("tel", "search.exactTel", { unique: false, multiEntry: true });

Let's do this (and the delete above) before you do the cursor stuff (it might be slightly faster).

Comment 12

[Etienne Segonzac (:etienne)]

Attachment: Patch v5

Updated patch with upgrade script fine tuning.

Comment 13

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78ffcc4b0ba5

Comment 14

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/1e07f2621fb5

Comment 15

[Johnny Stenback (:jst)]

Marking FIXED as this is landed on inbound and b2g18.

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/78ffcc4b0ba5