827345 - Self-serve "generate nightly builds on revision X" doesn't work with B2G nightlies

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Ed Morley [:emorley]]

I've just used it on the tip of https://tbpl.mozilla.org/?tree=Mozilla-B2g18 and only the desktop Nightlies were generated.

I believe there are at least two problems:

1) util.py expects there to be a space before "nightly", whereas the B2G builds all use "_nightly": https://hg.mozilla.org/build/buildapi/file/ce9124511033/buildapi/model/util.py#l97

2) do_new_nightly_at_revision() also presumes a leading space before "nightly": https://hg.mozilla.org/build/buildapi/file/ce9124511033/buildapi/scripts/selfserve-agent.py#l463

That said, we also didn't get any builds on "b2g_mozilla-b2g18_ics_armv7a_gecko nightly", which does include the leading space - so presume there is a third issue as well.

Comment 1

[Ed Morley [:emorley]]

Just had to respin on m-c, the two B2G jobs didn't trigger and had to be started manually (plus side is I now know how to do this myself :-)):
b2g_mozilla-central_ics_armv7a_gecko nightly
b2g_mozilla-central_unagi_nightly

Comment 2

[Ed Morley [:emorley]]

Though that said, my manually triggered builds are missing these properties:
{
buildid 	20130108030922 	buildIDSchedFunc
builduid 	1d37563ea3ae452fba5790554f318e21 	buildUIDSchedFunc
compare_locales_revision 	1fc4e9bc8287 	SetProperty Step
gaia_revision 	99d7597d2be3 	SetProperty Step
}

Guess I needed to include them myself

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

The last two are set in build steps so can be left off; the other two by the scheduler, not sure what the right thing is to do there.

Comment 4

[Ed Morley [:emorley]]

There weren't any complaints about the generated builds, so hoping it didn't matter after all :-0

Comment 5

[Ed Morley [:emorley]]

:-) even

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Taking this so devs/relman have a self-serve way to order up b2g nightlies over the weekend.

(In reply to Ed Morley [:edmorley UTC+0] from comment #0)
> I believe there are at least two problems:
> 
> 1) util.py expects there to be a space before "nightly", whereas the B2G
> builds all use "_nightly":
> https://hg.mozilla.org/build/buildapi/file/ce9124511033/buildapi/model/util.
> py#l97

This is reporting issue only, I think.
 
> 2) do_new_nightly_at_revision() also presumes a leading space before
> "nightly":
> https://hg.mozilla.org/build/buildapi/file/ce9124511033/buildapi/scripts/
> selfserve-agent.py#l463

This is the problem to fix.
 
> That said, we also didn't get any builds on
> "b2g_mozilla-b2g18_ics_armv7a_gecko nightly", which does include the leading
> space - so presume there is a third issue as well.

That doesn't match '% mozilla-central nightly' so is excluded too.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildapi] change magic string to find nightlies

Before:
mysql> SELECT DISTINCT buildername FROM buildrequests WHERE buildername LIKE '% mozilla-b2g18 nightly' AND submitted_at > 1356656441;
+------------------------------------+
| buildername                        |
+------------------------------------+
| Linux mozilla-b2g18 nightly        |
| Linux x86-64 mozilla-b2g18 nightly |
| OS X 10.7 mozilla-b2g18 nightly    |
| WINNT 5.2 mozilla-b2g18 nightly    |
+------------------------------------+
4 rows in set (22.11 sec)

After:
mysql> SELECT DISTINCT buildername FROM buildrequests WHERE buildername LIKE '%mozilla-b2g18%nightly' AND buildername NOT LIKE '%l10n nightly' AND submitted_at > 1356656441;
+----------------------------------------------------+
| buildername                                        |
+----------------------------------------------------+
| b2g_mozilla-b2g18_ics_armv7a_gecko nightly         |
| b2g_mozilla-b2g18_linux32_gecko nightly            |
| b2g_mozilla-b2g18_linux32_gecko_localizer nightly  |
| b2g_mozilla-b2g18_linux64_gecko nightly            |
| b2g_mozilla-b2g18_linux64_gecko_localizer nightly  |
| b2g_mozilla-b2g18_macosx64_gecko nightly           |
| b2g_mozilla-b2g18_macosx64_gecko_localizer nightly |
| b2g_mozilla-b2g18_otoro_nightly                    |
| b2g_mozilla-b2g18_unagi_nightly                    |
| b2g_mozilla-b2g18_unagi_eng_nightly                |
| b2g_mozilla-b2g18_unagi_stable_nightly             |
| b2g_mozilla-b2g18_win32_gecko nightly              |
| b2g_mozilla-b2g18_win32_gecko_localizer nightly    |
| Linux mozilla-b2g18 nightly                        |
| Linux x86-64 mozilla-b2g18 nightly                 |
| OS X 10.7 mozilla-b2g18 nightly                    |
| WINNT 5.2 mozilla-b2g18 nightly                    |
+----------------------------------------------------+
17 rows in set (18.81 sec)


The change of style in the last hunk is to avoid the unreadable 
  "%%%s%%nightly" % branch

Don't have a staging env for this, so untested.

Comment 8

[Ed Morley [:emorley]]

Thank you for taking this :-)

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 700796 [details] [diff] [review]
[buildapi] change magic string to find nightlies

http://hg.mozilla.org/build/buildapi/rev/0bb3e16ba8cb

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Got auto-deployed and was able to force a nightly on date. Bug 829407 for the reporting issue.