Closed
Bug 827436
Opened 11 years ago
Closed 11 years ago
js/src/shell/js.cpp:4733: warning: 'int OptionFailure(const char*, const char*)' defined but not used
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.15 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
When building gecko for B2G, I got this build warning:
{
js/src/shell/js.cpp:4733: warning: 'int OptionFailure(const char*, const char*)' defined but not used
}
Looks like this function is defined unconditionally, but it's only called in an #if defined(JS_ION) chunk, as shown by this cset which added the function:
https://hg.mozilla.org/mozilla-central/diff/8db8eef79b8c/js/src/shell/js.cpp
I think we should just #ifdef-guard the function definition.
|
Assignee | |
Updated•11 years ago
|
Blocks: buildwarning
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Updated•11 years ago
|
Attachment #698798 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/36a681f8f124
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/36a681f8f124
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•