827545 - Create mozpool python package

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Armen [:armenzg]]

We should also modify b2g_panda.py to use this once completed.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Mozpool's not on pypi yet, but I've no problem seeing it uploaded.  Please add Mark and I as package admins there, too.

From our vidyo conversation, if this bug involves writing a Mozpool client library (separate from the mozharness-based library jhopkins wrote), it'd be great to see that library included directly in the mozpool repo.  Then users can install 'mozpool', and use either the client or server portion, as they prefer.  It also means that we can make non-backward-compatible API changes to both client and server at the same time, and even test that they work together correctly.

Comment 2

[Armen [:armenzg]]

Attachment: mozpool package

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 702859 [details] [diff] [review]
mozpool package

Review of attachment 702859 [details] [diff] [review]:
-----------------------------------------------------------------

I think this should be in the same Python package as the rest of mozpool - so no distinct setup.py.  It should be *the same* project - so no separate CHANGES.txt, no separate README.txt, etc.  Just a few extra Python files added to mozpool.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

I see mozpoolclient-0.1.0 added to the python packages in puppetagain.  Is that this, or is that jhopkins' mozpool client?  I noticed that it uses the package name 'mozpool', which will make it impossible to install in the same virtualenv as mozpool.

Comment 5

[Armen [:armenzg]]

Attachment: mozpoolclient package

We spoke on IRC and we decided that is best to make the client part lightweight and not need all other packages needed by the whole mozpool stack.

This package only needs "request".

I have tested the package and it works.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 706539 [details] [diff] [review]
mozpoolclient package

Looks good to me!

Comment 7

[Armen [:armenzg]]

http://hg.mozilla.org/build/mozpool/rev/3d10d9547e73

Comment 8

[Armen [:armenzg]]

Attachment: make requests necessary

I don't know at which point I lost this line in my patches.

Comment 9

[Armen [:armenzg]]

Comment on attachment 707236 [details] [diff] [review]
make requests necessary

http://hg.mozilla.org/build/mozpool/rev/e352d25b75b0

Comment 10

[Armen [:armenzg]]

Thanks!