827638 - dailymotion.com doesn't recognize B2G UA as mobile

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

dailymotion.com serves a desktop site to B2G. Bug 819210 added an UA override for this domain. The override should be removed once the domain serves mobile content to B2G. This bug tracks the evangelism for the site to recognize the B2G UA and the removal of the override at that time.

Comment 1

[Anthony Ricaud (:rik)]

I'll try and use Twitter to find a contact.

Here's a pointer to our UA reference: https://developer.mozilla.org/en-US/docs/Gecko_user_agent_string_reference

Specifically, it looks like this: "Mozilla/5.0 (Mobile; rv:15.0) Gecko/18.0 Firefox/18.0"

Comment 2

[Anthony Ricaud (:rik)]

Found a contact, an internal ticket is open: https://twitter.com/inside_/status/304967625425952768

Comment 3

[Jason Smith [:jsmith]]

(In reply to Anthony Ricaud (:rik) from comment #2)
> Found a contact, an internal ticket is open:
> https://twitter.com/inside_/status/304967625425952768

Awesome. Thanks for the help!

Comment 4

[David Landgren]

Hi, I amended our UA detection code as per your reference docs, and this has been released to production. I've subscribed to this ticket, but in case I don't see update, feel free to email me at firstname dot lastname at companyname dot com

Comment 5

[Anthony Ricaud (:rik)]

Attachment: Proposed patch

Excellent, thank you! I've tested and confirmed the UA detection works on the device.

Comment 6

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/50adf819f1b1a98b0943870260651c1f50fe598b

I think there is no risk to land this on all branches so requesting tef+.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 4cfed54b3937d9d2510ec5ca766895f5996097cd

This patch seems to already be on v1.0.1:

 $ git cherry-pick 88ad3ded48e01c3afa26b70bc9dac9e435395c5f
# On branch v1.0.1
# You are currently cherry-picking.
#   (all conflicts fixed: run "git commit")
#
nothing to commit (working directory clean)
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git reset'

Comment 8

[Cody Roesch [:croesch]]

Build: 20130322070202
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/5aacf880400b
Gaia   5a31a56b96a8fc559232d35dabf20411b9c2ca1d
Kernel: Dec 5th

On the build above, I've tested all the areas of Dailymotion.com and even added it to the home page to check in that fashion. It appears in the Mobile format unless you turn off the option for Redirect to Webapp.

Marking as Verified Fixed.