Closed Bug 827684 Opened 11 years ago Closed 11 years ago

Memory leak of OmxDecoder if Init fails on Android

Categories

(Core :: Audio/Video, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: cajbir, Assigned: drexler)

Details

Attachments

(1 file)

media/omx-plugin/OmxPlugin.cpp has the following in CreateDecoder:

  OmxDecoder *omx = new OmxDecoder(aPluginHost, aDecoder);
  if (!omx || !omx->Init())
    return false;

This will leak an instance of OmxDecoder if the allocation is successful but the Init call is not.
Attached patch fixSplinter Review
Attachment #730185 - Flags: review?(chris.double)
Attachment #730185 - Flags: review?(chris.double) → review+
Assignee: nobody → andrew.quartey
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/7d1b8ee0e1bd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: