827806 - 'geolocation' permission should be set to prompt for certified apps

Status: VERIFIED FIXED

(Core :: Permission Manager, defect)

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

I will let Jonas do the reasoning :) 
Basically, E.me runs in the homescreen and since the homescreen is a certified app, E.me doesn't prompt for geolocation.

Comment 3

[Jason Smith [:jsmith]]

Makes sense, but I have a question (that I brought up in person):

If we now make geolocation PROMPT_ACTION for certified apps, shouldn't we know see those certified apps in the settings apps perms UI as a result and be able to control the geolocation permissions off that UI?

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 699173 [details] [diff] [review]
patch

Review of attachment 699173 [details] [diff] [review]:
-----------------------------------------------------------------

Let's do this for now, but we should bring this up on the mailing list.

Comment 5

[Jason Smith [:jsmith]]

Putting needsinfo on Josh to think about the UX implications here.

comment 3 would be an example to think about.

Comment 6

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d13052681690

Comment 7

[Jason Smith [:jsmith]]

Talked with jcarpenter in person - we're just going to reuse the existing apps perms UI for v1.

Comment 8

[Gregor Wagner [:gwagner]]

Followup: https://hg.mozilla.org/integration/mozilla-inbound/rev/0f28e7c859c8

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d13052681690
https://hg.mozilla.org/mozilla-central/rev/0f28e7c859c8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/2fb4aa15cc2f
https://hg.mozilla.org/releases/mozilla-b2g18/rev/9335c82bcbc5

Comment 11

[Jason Smith [:jsmith]]

Confirmed we are getting prompts, but the remember my choice default isn't right. Followup coming.