Closed
Bug 827931
Opened 11 years ago
Closed 11 years ago
[B2G][Clock]Edit Mode: X icon for cancel edit not shown it show the back < arrow.
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Tracking
(b2g18 fixed)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
b2g18 | --- | fixed |
People
(Reporter: mbyrd, Assigned: pivanov)
Details
(Whiteboard: visual design, BerlinWW, UX-P4, testrun 2, landed in uxbranch, qa-verified)
Attachments
(3 files)
Issue: When selecting an existing alarm to edit, the top left icon shows as a < back icon not X to cancel edit Steps to Reproduce: 1) Install Build 20130104070203 v.1 on a Unagi Device 2) Select Clock app 3) Select + in upper right hand corner (to add new alarm) 4) Select a time and label for new alarm 5) Select done (alarm is added to alarm page) 6) Select alarm that was just added to open in edit mode 7.) Make changes to existing alarm 8.) Look to top left to cancel changes Expected: Per test case #2052 alarm settings and press "X" button on the top-left corner to cancel changes Actual: Icon on the top-left corner is < back arrow to cancel changes Notes: Repro frequency: Repros 10/10 times, checked on different devices Included screen shot. This could be a test case edit.
Comment 1•11 years ago
|
||
The style of the back button is a building block of header section. Josh, Is it an issue? Or, the test case is needed to update. Thanks.
Flags: needinfo?(jcarpenter)
Comment 2•11 years ago
|
||
Hi Ian, Misty is right: if you have time, we should change the "<" to and "x" instead.
Flags: needinfo?(jcarpenter)
Updated•11 years ago
|
Whiteboard: visual design, BerlinWW, UX-P4
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → pivanov
Assignee | ||
Updated•11 years ago
|
Whiteboard: visual design, BerlinWW, UX-P4 → visual design, BerlinWW, UX-P4, landed in uxbranch
Assignee | ||
Updated•11 years ago
|
Whiteboard: visual design, BerlinWW, UX-P4, landed in uxbranch → visual design, BerlinWW, UX-P4
Comment 3•11 years ago
|
||
I see Pavel has taken the issue. Thanks.
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Comment 5•11 years ago
|
||
NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed: Risk to taking this patch (and alternatives if risky):
Attachment #700346 -
Flags: review?(kaze)
Attachment #700346 -
Flags: review?(jcarpenter)
Attachment #700346 -
Flags: approval-gaia-master?(21)
Updated•11 years ago
|
Attachment #700346 -
Flags: review?(jcarpenter) → review+
Updated•11 years ago
|
Attachment #700346 -
Flags: review?(kaze) → review+
Comment 6•11 years ago
|
||
Comment on attachment 700346 [details]
patch for Gaia repo
Basically just switching CSS styles, very low risk for UX gain. approval-gaia-master+
Attachment #700346 -
Flags: approval-gaia-master?(21) → approval-gaia-master+
UCID: clock-004 https://moztrap.mozilla.org/results/case/61317/
Whiteboard: visual design, BerlinWW, UX-P4 → visual design, BerlinWW, UX-P4, testrun 2
Comment 8•11 years ago
|
||
Landed in UX Branch https://github.com/gordonbrander/gaia/commit/76931c135fca26b7a1b8edd8031cfc435b643091
Whiteboard: visual design, BerlinWW, UX-P4, testrun 2 → visual design, BerlinWW, UX-P4, testrun 2, landed in uxbranch
Comment 9•11 years ago
|
||
defects still reproduces on the Unagi device Build ID: 20130115070201 using the dec 5th kernel
yes, ahubenya, you will still see this issue in the main branch; this is a uxbranch fix. Question : are all cancel items suppose to have x instead of < ?
Whiteboard: visual design, BerlinWW, UX-P4, testrun 2, landed in uxbranch → visual design, BerlinWW, UX-P4, testrun 2, landed in uxbranch, qa-verified
Comment 11•11 years ago
|
||
(In reply to Naoki Hirata :nhirata from comment #10) > Question : are all cancel items suppose to have x instead of < ? If there’s an action button (“Done”, “Save”, etc.) in the top-right corner then it’s a dialog. If it’s a dialog, the cancel button should be an "x", not a "<".
Updated•11 years ago
|
Hardware: x86_64 → ARM
Updated•11 years ago
|
OS: Windows 7 → Gonk (Firefox OS)
Comment 12•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/5cb6a64dbf643e2c8774f4aadedd57a6e0d6dafb
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
QA Contact: jshih → fyen
status-b2g18:
--- → fixed
Comment 13•11 years ago
|
||
Gaia: 6c53dfd2e5d60393f6a57e9e1a4b5af6a3d6a783 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/2226f181c8c2 BuildID 20130126070202 Version 18.0 Verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•