827931 - [B2G][Clock]Edit Mode: X icon for cancel edit not shown it show the back < arrow.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Misty Byrd]

Attachment: screen shot for edit alarm icon

Issue: When selecting an existing alarm to edit, the top left icon shows as a < back icon not X to cancel edit 

 Steps to Reproduce:

1) Install Build 20130104070203 v.1 on a Unagi Device
 2) Select Clock app
3) Select + in upper right hand corner (to add new alarm)

 4) Select a time and label for new alarm

 5) Select done (alarm is added to alarm page)

 6) Select alarm that was just added to open in edit mode

7.) Make changes to existing alarm

8.) Look to top left to cancel changes


Expected: Per test case #2052  alarm settings and press "X" button on the top-left corner to cancel changes

Actual:
Icon on the top-left corner is < back arrow to cancel changes

Notes:
Repro frequency:
Repros 10/10 times, checked on different devices
Included screen shot. This could be a test case edit.

Comment 1

[[e-mail], [e-mail]]

The style of the back button is a building block of header section.

Josh,
Is it an issue?
Or, the test case is needed to update.
Thanks.

Comment 2

[Josh Carpenter [:jcarpenter]]

Hi Ian, Misty is right: if you have time, we should change the "<" to and "x" instead.

Comment 3

[[e-mail], [e-mail]]

I see Pavel has taken the issue.
Thanks.

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for UX branch

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 6

[Ben Francis [:benfrancis]]

Comment on attachment 700346 [details]
patch for Gaia repo

Basically just switching CSS styles, very low risk for UX gain. approval-gaia-master+

Comment 7

[amiller]

UCID: clock-004
https://moztrap.mozilla.org/results/case/61317/

Comment 8

[Sam Joch [:samjoch]]

Landed in UX Branch https://github.com/gordonbrander/gaia/commit/76931c135fca26b7a1b8edd8031cfc435b643091

Comment 9

[Angela Hubenya]

defects still reproduces on the Unagi device Build ID: 20130115070201   using the dec 5th kernel

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

yes, ahubenya, you will still see this issue in the main branch; this is a uxbranch fix.

Question : are all cancel items suppose to have x instead of < ?

Comment 11

[Fabien Cazenave [:kaze]]

(In reply to Naoki Hirata :nhirata from comment #10)
> Question : are all cancel items suppose to have x instead of < ?

If there’s an action button (“Done”, “Save”, etc.) in the top-right corner then it’s a dialog. If it’s a dialog, the cancel button should be an "x", not a "<".

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/5cb6a64dbf643e2c8774f4aadedd57a6e0d6dafb

Comment 13

[Askeing Yen[:askeing][:fyen]]

Gaia:     6c53dfd2e5d60393f6a57e9e1a4b5af6a3d6a783
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/2226f181c8c2
BuildID   20130126070202
Version   18.0

Verified.