828127 - [Needinfo] One user can needinfo multiple times from the same person

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Walter Chen[:ypwalter][:wachen]]

https://bugzilla.mozilla.org/show_bug.cgi?id=827535

mvines: 	needinfo 	[e-mail]
shuang: 	needinfo 	[e-mail]
wachen: 	needinfo 	[e-mail]
wachen: 	needinfo 	[e-mail]

Also, one can still add more needinfo from the same person.

Comment 1

[Walter Chen[:ypwalter][:wachen]]

There are two aspects of this bug:
1. multiple people requesting from the same person:   Acceptable
2. same people requesting multiple times from another person:   Strange

Comment 2

[David Lawrence [:dkl]]

Attachment: Patch to disallow same requestee muliple times for needinfo (v1)

Comment 3

[:glob ✱]

Comment on attachment 703582 [details] [diff] [review]
Patch to disallow same requestee muliple times for needinfo (v1)

r=glob, with the following to be fixed on commit:

>+                next if $flag->requestee->login != $needinfo_flag->{requestee};

that needs to be 'ne' not '!='.

Comment 4

[David Lawrence [:dkl]]

Thanks

Committing to: bzr+ssh://[e-mail]/bmo/4.0   
modified extensions/Needinfo/Extension.pm
Committed revision 8446.

Committing to: bzr+ssh://[e-mail]/bmo/4.2   
modified extensions/Needinfo/Extension.pm
Committed revision 8510.