828234 - fix mingw build of nsTextStore.cpp

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Trevor Saunders (:tbsaunde)]

it would seem gcc doesn't like implicitly converting nsRefPtr<foo> to vid*.

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: bug 828234 - fix nsTextStore.cpp build on mingw

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 699796 [details] [diff] [review]
bug 828234 - fix nsTextStore.cpp build on mingw

>@@ -2229,17 +2229,17 @@ nsTextStore::InsertTextAtSelectionInternal(const nsAString &aInsertStr,
>     }
>     aTextChange->acpNewEnd = newSelection.acpEnd;
>   }
> 
>   PR_LOG(sTextStoreLog, PR_LOG_DEBUG,
>          ("TSF: 0x%p   nsTextStore::InsertTextAtSelectionInternal() succeeded: "
>           "mWidget=0x%p, mWidget->Destroyed()=%s, aTextChange={ acpStart=%ld, "
>           "acpOldEnd=%ld, acpNewEnd=%ld }",
>-          this, mWidget, GetBoolName(mWidget ? mWidget->Destroyed() : true),
>+          this, mWidget.get(), GetBoolName(mWidget ? mWidget->Destroyed() : true),

This line is over 80 characters. GetBoolName() should be in next line.

Comment 3

[Trevor Saunders (:tbsaunde)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c2b63f72f67

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2c2b63f72f67