828796 - Radio doesn't remember the last station used (defaults to 87.5 MHz)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[Matthew N. [:MattN]]

The FM Radio app should remember the last played station rather than playing 87.5 MHz on launch (which happens to be just interference for me).

Build ID: 20130108070203

Comment 1

[John Shih]

should be a polish, not a blocker
I think what you mean might be after reboot the phone (or simply, kill the app from cardview) and launch the Radio app, app should remember the last played station
it that correct?

Comment 2

[Matthew N. [:MattN]]

Yes, remember the station after rebooting or killing the app.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I filed this a long time ago, thought it was fixed ...

Comment 4

[Erwan LE BESCOND]

My first contribution to discover the project ... Only tested with desktop client

https://github.com/mozilla-b2g/gaia/pull/7695

Comment 5

[Erwan LE BESCOND]

Attachment: https://github.com/mozilla-b2g/gaia/pull/7695

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 704337 [details]
https://github.com/mozilla-b2g/gaia/pull/7695

Looks good over all, some nits needs to be addressed before merging.

Please re-request for review when you correct these. Good job, thanks!

Comment 7

[Erwan LE BESCOND]

Attachment: https://github.com/mozilla-b2g/gaia/pull/7695

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 704510 [details]
https://github.com/mozilla-b2g/gaia/pull/7695

r=me, thank you for patching Gaia :)

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/commit/d037659dd50e647d3c0e70c47210045098763fb8

Landed to master. Waiting for blocking-b2g? decision to land on v1-train.

Comment 10

[Askeing Yen[:askeing][:fyen]]

Gaia:     6c53dfd2e5d60393f6a57e9e1a4b5af6a3d6a783
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/2226f181c8c2
BuildID   20130126070202
Version   18.0

Verified.