828843 - Remove feedback app from release builds

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jason Smith [:jsmith]]

The feedback app should only be part of dogfooding builds. Are we making sure production release builds don't contain this app?

The unagi builds being generated right now include this app by default.

Comment 1

[Josh Carpenter [:jcarpenter]]

Lukkas, are we still getting feedback from the Feedback app? We (triagers) know we need to pull this from final release, but are unsure whether we should do so now, or wait, if valuable feedback is still coming through.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

We'll need this in beta builds and then, correctly, not in release builds.  Including some release engineering folks to determine if we can set this up.

Comment 3

[[e-mail] (:bhearsum)]

What flags/bit/env vars need to be flipped to remove or include the Feedback app in builds?

Comment 4

[Chris AtLee [:catlee]]

If there's a make/mozconfig or other variable that can be set to disable this, then we can flip that setting. If there's no such control, we should probably add it now. This won't be the first time we need to remove the feedback app!

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Let's add a |make dogfood|

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 704828 [details] [diff] [review]
Patch

Looks good, seems like a good approach in order to eventually reintroduce marketplace-dev in trunk.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/892759344cf4bf0acd593b7d8643bcc56315f842

Comment 8

[Natalya Kot [:nkot]]

Smoketest regression
Unagi build 2013-01-23-07-02-02, Kernel Dec 5

verified fixed - Feedback app is no longer displayed

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

So RelEng should now set DOGFOOD=1 when calling ./build.sh for the builds that end up on nightly & beta channels  ?

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Or perhaps add 'dogfood' as an argument to the build.sh call.

Comment 11

[[:fabrice] Fabrice Desré]

https://github.com/mozilla-b2g/gaia/commit/d26e5ce7efcb2d1ddbee01799917fa6417e10980

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.