Closed
Bug 82888
Opened 23 years ago
Closed 23 years ago
Validation prefs tab needs cleanup
Categories
(Core Graveyard :: Security: UI, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
psm2.0
People
(Reporter: lord, Assigned: ddrinan0264)
Details
(Whiteboard: PDT+; critical for 0.9.2)
Attachments
(1 file)
1.34 KB,
patch
|
Details | Diff | Splinter Review |
The OCSP section of the Validation pref tab needs a number of changes. (1) The URL and the Signer areas should be reversed. (This relates to #2 to improve flow.) (2) When you select a Signer whose cert contains the AIA extension, the system should auto-populate that extension into the URL field. (3) The list of Signers should be sorted so that the certs with the AIA extension are filtered to the top (and then sorted alphabetically). There should be a horizontal rule between the top list (which contains certs with AIA extensions) and the bottom list (without the extensions). A sample list would be: Abc corp RTFM corp XYZ corp --- AAA Corp Bbbb Inc. ... (4) The URL text area is locked. I can't enter in any text there. (5) Some Signer names are too long, so the button extends off the edge of the window. Perhaps we should clip the names at 20 (25? 30?) characters. Regarding #3, this organization may not be the best to easily convey the meaning between the certs. It will not be intuitive why company X has certs both above and below the line. Smart users will figure it out, but it will take some sleuthing. Another option would be to leave the list sorted as, but to put the certs with AIA extensions in bold, or to someone tag them as being special.
Updated•23 years ago
|
Whiteboard: PDT+ → PDT+; eta 6/22
Assignee | ||
Comment 6•23 years ago
|
||
Comment 7•23 years ago
|
||
r=javi
Assignee | ||
Comment 8•23 years ago
|
||
Chris, Please super-review.
Whiteboard: PDT+; eta 6/22 → PDT+; need sr=, need a=
Comment 9•23 years ago
|
||
Ready for sr=, a= Thanks
Reporter | ||
Comment 10•23 years ago
|
||
David, that patch only seems to cover change #1. Were you going to propose a patch to cover change #5 later?
Comment 11•23 years ago
|
||
Does #5 mean the button is not visible or is not clickable? If either is the case, then that would be critical to fix. If the button is clickable but looks a little goofy then we've got enough to be worth getting in today (UI localization freeze is 6/26.) Who is the sr= person for this bug?
Comment 12•23 years ago
|
||
I was the sr person for this bug but I told the person who requested the super-review to respond to bob's comments first.
Reporter | ||
Comment 13•23 years ago
|
||
Note regarding #5: while the button is "at rest" it should be truncated to fit in the window. But when you click on it and the popup list is exposed, you should see the entire name of the CA. If that's not a simple change, then we should just complete #1 (which I think we have), and I'll open a new bug for the other remaining points to prevent too much bug morphing.
Comment 14•23 years ago
|
||
In that case Bob let me know if you want me to super-review just #1 then.
Assignee | ||
Comment 15•23 years ago
|
||
Bob, What you propose for #5 is not simple to do. So, as you suggest, the best is to check in #1 and open a new bug for the remaining deficiencies. Chris, Please just super-review #1.
Comment 16•23 years ago
|
||
whiteboard -> needs review.
Whiteboard: PDT+; need sr=, need a= → PDT+; needs review;
Comment 17•23 years ago
|
||
Chris, I think the consensus on this is to have you sr #1. Thanks
Comment 18•23 years ago
|
||
sr=blizzard, a=blizzard on behalf of drivers for 0.9.2
Whiteboard: PDT+; needs review; → PDT+; critical for 0.9.2
Assignee | ||
Comment 19•23 years ago
|
||
Fixed on branch and trunk.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•