Closed Bug 828890 Opened 11 years ago Closed 11 years ago

[Settings] Scroll bar should not go over the header

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18+ fixed, b2g18-v1.0.1 wontfix)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
b2g18 + fixed
b2g18-v1.0.1 --- wontfix

People

(Reporter: sergiov, Assigned: pivanov)

References

Details

(Whiteboard: visual design [UX-P1], TEF_REQ, PRODUCT-DELIGHT, uxbranch, landed in uxbranch)

Attachments

(2 files, 1 obsolete file)

Incorrect Scroll Bar :: Screenshot
56.34 KB, image/png
Details
patch for UX branch
179 bytes, text/html
dietrich
: approval-gaia-v1+
Details 
      No description provided.
Whiteboard: visual design, incorrect implementation
Whiteboard: visual design, incorrect implementation → visual design, incorrect implementation, BerlinWW
Assignee: nobody → pivanov
Attachment #700266 - Flags: feedback?(kaze)
I ask Kaze for feedback because the patch for this bug will contains extra DOM elements.
I guess I’m OK with that because it would get us rid of a few “position: fixed” rules, but I don’t think it’s a good idea to do this three days before the release, the risk-over-value ratio seems to high.
Attachment #700266 - Flags: feedback?(kaze)
Josh, what do you think?
Flags: needinfo?(jcarpenter)
Every other app does this right. Settings should too :)
Flags: needinfo?(jcarpenter)
Blocks: 815609
Josh, we’re not saying we shouldn’t do it: we’re wondering if it’s worth the risk at this point.

Pavel, can you fix bug 815609 and this one in the UX branch?
Attached file patch for Gaia repo (obsolete) — 

        Attachment #701573 -
        Flags: review?(kaze)
Blocks: 830111

    
    

    
  
Comment on attachment 701573 [details]
patch for Gaia repo

move to UX branch

        Attachment #701573 -
        Attachment is obsolete: true

        Attachment #701573 -
        Flags: review?(kaze)

    
    

    
  

      
      
      
      

        Attached file
          
        patch for UX branch
        — 
      

    


  

        Attachment #701584 -
        Flags: review?(kaze)

    
    

    
  
Comment on attachment 701584 [details]
patch for UX branch

clearing the review as it’s moved to the UX branch

        Attachment #701584 -
        Flags: review?(kaze)

    
  
Whiteboard: visual design, incorrect implementation, BerlinWW → visual design [UX-P1], TEF_REQ

        Attachment #701584 -
        Flags: review?(sjochimek)

        Attachment #701584 -
        Flags: review?(kaze)
Whiteboard: visual design [UX-P1], TEF_REQ → visual design [UX-P1], TEF_REQ, PRODUCT-DELIGHT

    
  

        Attachment #701584 -
        Flags: review?(sjochimek)

    
    

    
  
Landed in uxbranch: https://github.com/gordonbrander/gaia/commit/2321a9ab3feeb9a9b4217aa4d63f2a4af0b96903
Whiteboard: visual design [UX-P1], TEF_REQ, PRODUCT-DELIGHT → visual design [UX-P1], TEF_REQ, PRODUCT-DELIGHT, uxbranch, landed in uxbranch

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/25d9e53380db967d76223c5f1e1940ed907ed447
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
Master build : 2013-03-26-07-02-04
"mozilla-central" revision="28b048ffb7a7"
"integration/gaia-central" revision="44f6a17f24d4"
"gecko.git"revision="a800f14ea7022a78966f7fe14a9b0d11c569b151"
"gaia.git" revision="ace1eb32a313da1232bbdf9cff2581a4b036356d"

Verified on master, not on v1 train.
Status: RESOLVED → VERIFIED

          status-b2g18:
          --- → affected

    
    

    
  
Comment on attachment 701584 [details]
patch for UX branch

Is this ready to raise to approval? with user value and risk in the comments? Our goal is to wrap up all Yedo and VxD changes by April 5th.

    
    

    
  
Yes, I think so.

    
    

    
  
The master commit hash for this specific bug is 6bbe58edb16169c94dda6426ce77059d06d2a4fe.

    
    

    
  
Thanks, Pavel. Can you please raise to approval? - I tried but don't have the appropriate permissions. Sorry!

    
    

    
  
Comment on attachment 701584 [details]
patch for UX branch

clearing the r? as it’s been landed in the UX branch anyway.

        Attachment #701584 -
        Flags: review?(kaze)

    
    

    
  
Approval? still has not been raised on this. I would do it but I do not have permissions to do so. Please raise to approval so we can keep this moving for 1.1 and v1-train. Thank you!

    
    

    
  
Comment on attachment 701584 [details]
patch for UX branch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: see bug title
Testing completed: yes, QA checked on master
Risk to taking this patch (and alternatives if risky): very low, no logic change, small CSS change
String or UUID changes made by this patch: none

        Attachment #701584 -
        Flags: approval-gaia-v1?(21)

    
    

    
  
visual design change requesting trackingb2g18 nom

          tracking-b2g18:
          --- → ?

        Attachment #701584 -
        Flags: approval-gaia-v1?(21) → approval-gaia-v1+
Depends on: 858722

    
    

    
  
This should _not_ be uplifted without bug 858722.
No longer depends on: 858722
Depends on: 858722
Blocks: 854031

    
    

    
  
(In reply to Fabien Cazenave [:kaze] from comment #22)
> Merged on v1-train:
> https://github.com/mozilla-b2g/gaia/commit/
> 1a1e9b44e75252746bf5ebe343ee06fd3c300612
This commit unexpectedly merged partial patch of bug 830644 and causes style class in html is inconsistent with css definition. (grep "sim-code-area" in both files).

Furthermore, this patch also unexpectedly remove some DOM elements in settings/index.html and causes two regression bugs: bug 861215 and bug 861730. 
Sad. :'(

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: