829028 - Debugger should not interrupt the client twice at the same location

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Imagine following scenario:

 1. var a = 10;
*2. var b = 20;    // this line has a breakpoint
 3. var c = 30;

1) The script execution starts at line #1
2) The user steps-over and the next interrupt happens at line #2
3) The user steps-over and the next interrupt happens at line #2 again because of the breakpoint.

The debugger (server side) should be smart enough to recognize that the second interrupt (at the line #2) is not necessary (it's the same debugging location as where the debugger already is).

Honza

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

I think BA_hit should just continue instead of pausing, if onStep or onEnetrFrame hooks are set on the frame/debugger. Maybe only onStep, since stepping over a function could trigger breakpoints inside that function and perhaps pausing there would be expected?

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Don't pause twice on a breakpoint or debugger statement while stepping

This works but needs a test.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Don't pause twice on a breakpoint or debugger statement while stepping v2

Added tests for both cases described in comment 1.

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 776374 [details] [diff] [review]
Don't pause twice on a breakpoint or debugger statement while stepping v2

Review of attachment 776374 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/tests/unit/test_breakpoint-13.js
@@ +91,5 @@
> +      });
> +      // Step into the next line with the function call.
> +      gThreadClient.stepIn();
> +    });
> +  });

pretty.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/5be325efcdcf

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/5be325efcdcf