Closed
Bug 829258
Opened 11 years ago
Closed 11 years ago
Include missing @2x images in pinstripe/jar.mn
Categories
(Firefox :: Downloads Panel, defect)
Tracking
()
RESOLVED
FIXED
Firefox 21
Tracking | Status | |
---|---|---|
firefox20 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(1 file, 1 obsolete file)
2.24 KB,
patch
|
mak
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 812255 was awesome, because it landed sweet new hi-dpi graphics for the Downloads Panel. What wasn't awesome, was that it forgot to include those graphics in jar.mn.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → mconley
Attachment #700649 -
Flags: review?(mak77)
Assignee | ||
Comment 2•11 years ago
|
||
We need download-summary too.
Attachment #700649 -
Attachment is obsolete: true
Attachment #700649 -
Flags: review?(mak77)
Assignee | ||
Updated•11 years ago
|
Summary: Actually include buttons@2x.png in jar.mn → Include missing @2x images in pinstripe/jar.mn
Assignee | ||
Updated•11 years ago
|
Attachment #700655 -
Flags: review?(mak77)
Comment 3•11 years ago
|
||
Comment on attachment 700655 [details] [diff] [review] Patch v2 Review of attachment 700655 [details] [diff] [review]: ----------------------------------------------------------------- thanks!
Attachment #700655 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Thanks - landed on mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/bafcf4095439
Comment 5•11 years ago
|
||
Comment on attachment 700655 [details] [diff] [review] Patch v2 [Approval Request Comment] Bug caused by (feature/regressing bug #): Downloads panel feature User impact if declined: incomplete ui Testing completed (on m-c, etc.): m-i (merge pending) Risk to taking this patch (and alternatives if risky): limited to the feature String or UUID changes made by this patch: none
Attachment #700655 -
Flags: approval-mozilla-aurora?
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bafcf4095439
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bafcf4095439
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bafcf4095439
Updated•11 years ago
|
Attachment #700655 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/f8bbe9e65621
status-firefox20:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•