829511 - New “first launch” interactions for the Cost Control app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Rafael Rebolleda]

Attachment: Wireframe with new strings

Comment 1

[Fabien Cazenave [:kaze]]

For consistency, the back/next/… buttons should be in title case. Same thing for the titles, obviously.

“Controle” is not an English word, maybe you meant “Controlled”?

FWIW I don’t think these titles can fit in our headers without breaking the style consistency, and as an l10n devil I’d consider this as a blocker — when we talked about these CostControl screens, the point was precisely to allow a proper localization.

Comment 2

[Rafael Rebolleda]

Yup. Uploaded this on behalf of Marco at Salva's request. Anyway, I'll ask him to chime in.

Comment 3

[Jason Smith [:jsmith]]

Use tef? + tracking-b2g? now. We've retired blocking-basecamp? as of mid-day Friday.

Comment 4

[David Scravaglieri [:scravag]]

Daniel, is it a blocker this comes late in the game.

Comment 5

[Daniel Coloma:dcoloma]

I assume this is only a localization change, and the WF are still the same, correct?

Comment 6

[Fabien Cazenave [:kaze]]

No: it’s a (better but) different UI. On the localization front, I’m afraid neither the current UI nor this one can be properly localized because of the too long titles.

At the moment, each panel has one long and unclear title + one option, the rest of the screen being blank. If we want to ensure a proper internationalization with low risk, I’d suggest to stick to the current UI with shorter titles and add explanation texts in each panel. </my2¢>

Comment 7

[Rafael Rebolleda]

I've cc'd and passed this issue to Tyler, who's reviewing the strings (EN + ES)

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Is this going to be a string change only?  If so, no need to tef+ but if there are code/UI changes required here please comment on the criticality of those fixes for v1.0

Comment 9

[Salvador de la Puente González [:salva]]

This requires code or markup but it is not a string change only at all.

Comment 10

[David Scravaglieri [:scravag]]

Daniel, do you want to go through these late and maybe risky changes based on comment 6 ? If so please renominate.

Comment 11

[Salvador de la Puente González [:salva]]

Comment on attachment 700965 [details]
Wireframe with new strings

What about the flow fort NON-VIVO SIMs?

Comment 12

[Fabien Cazenave [:kaze]]

Some of the issues I mentioned in comment #1 are still not addressed:

 • the back/next/… buttons should be in title case (i.e. Back/Next/…)
 • the panel titles should be in title case, too
 • “Controle” is not an English word, maybe you meant “Controlled”?

FTR I don’t think that “I’m prepaid / Controle” makes much sense. I understand the Spanish “Prepago” better — and you know how bad my Spanish is. ;-)

Comment 13

[Salvador de la Puente González [:salva]]

(In reply to Fabien Cazenave [:kaze] from comment #12)
> Some of the issues I mentioned in comment #1 are still not addressed:
> 
>  • the back/next/… buttons should be in title case (i.e. Back/Next/…)

They are in title case in the implementation but not in the WF

>  • the panel titles should be in title case, too

Why? Is there a convention? If so, there is no problem changing it. Just clarifying why.

>  • “Controle” is not an English word, maybe you meant “Controlled”?

We are removing "controle" from the implementation as it is very dependent of VIVO. It is "prepaid" only.

Comment 14

[Fabien Cazenave [:kaze]]

(In reply to Salvador de la Puente González [:salva] from comment #13)
> Why? Is there a convention? If so, there is no problem changing it. Just
> clarifying why.

Yes, it’s a UX convention that has been applied on all Gaia apps (or should have).

> >  • “Controle” is not an English word, maybe you meant “Controlled”?
> 
> We are removing "controle" from the implementation as it is very dependent
> of VIVO. It is "prepaid" only.

Oh, so “Controle” is the name of the VIVO data plan? I’ll try to think of a way to let partners customize l10n strings… but that’s outside of the scope of this bug.

Comment 15

[marcoc]

(In reply to Salvador de la Puente González [:salva] from comment #11)
> Comment on attachment 700965 [details]
> Wireframe with new strings
> 
> What about the flow fort NON-VIVO SIMs?

Salva,
From the attached flow use the 2 screens from the Postpaid flow (bottom line) and make the following header and copy adjustments as we are not tracking telephony usage:

1st. 
header: Phone and data report -> Data report
hint text: Receive reports about your phone and internet usage. -> Receive reports about your internet usage.

2nd. 
header: Data report (leave as is)
hint text: Set an alert to avoid using too much data. (leave as is)

Comment 16

[Salvador de la Puente González [:salva]]

Attachment: Adding hints to Cost Control FTE

Bug caused by (feature/regressing bug #): this one
User impact if declined: medium
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 705277 [details]
Adding hints to Cost Control FTE

So far, being a tracking-b2g18+ I think you don't need the approval anymore, any way, this changes are harmless

Comment 18

[Staś Małolepszy :stas]

Comment on attachment 705277 [details]
Adding hints to Cost Control FTE

This patch removes some strings and I'd like to know if it's going to be uplifted to 1.0.x?  If not, we need a version of the patch which doesn't remove any strings.

Comment 19

[Salvador de la Puente González [:salva]]

It is tracking-b2g18+ so I understand this will end in v1.0.1
Am I wrong?

Comment 20

[Axel Hecht [:Pike]]

You'll need approval-gaia-v1 to land it on v1-train, unless it's tef+ or shira+.

Also, I'm rethinking l10n a tad just now as I get a better understanding of release trains, we shouldn't remove strings from the v1-train, at least for now.

Comment 21

[Salvador de la Puente González [:salva]]

Comment on attachment 705277 [details]
Adding hints to Cost Control FTE

This should land on shira so asking for approval again.

Comment 22

[Axel Hecht [:Pike]]

Please don't land this with the removal of the 1.0.0 strings.

Comment 23

[Salvador de la Puente González [:salva]]

So, what do you need Stas, a patch without removing former strings?

Comment 24

[Salvador de la Puente González [:salva]]

Once talked with Stas, we agree on leaving the former strings and open a followup bug asking for removing those strings.

Comment 25

[Salvador de la Puente González [:salva]]

Followup bug #835307

Comment 26

[Staś Małolepszy :stas]

Comment on attachment 705277 [details]
Adding hints to Cost Control FTE

Thanks, Salva!

Comment 27

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 705277 [details]
Adding hints to Cost Control FTE

dom change, harmless and will make the user to understand the app better.

a=me

Comment 28

[Salvador de la Puente González [:salva]]

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/59429d56ab0a6827c70f53683cb3b4a3d46e72ae

Comment 29

[Axel Hecht [:Pike]]

(In reply to Francisco Jordano [:arcturus] from comment #27)
> Comment on attachment 705277 [details]
> Adding hints to Cost Control FTE
> 
> dom change, harmless and will make the user to understand the app better.
> 
> a=me

This is not a harmless DOM change, but an l10n impact rework piece. I don't think we should approve this lightly.

Comment 30

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Axel Hecht [:Pike] from comment #29)
> (In reply to Francisco Jordano [:arcturus] from comment #27)
> > Comment on attachment 705277 [details]
> > Adding hints to Cost Control FTE
> > 
> > dom change, harmless and will make the user to understand the app better.
> > 
> > a=me
> 
> This is not a harmless DOM change, but an l10n impact rework piece. I don't
> think we should approve this lightly.

Hi Axel, this is a harmless change in terms of not JS modified. Also the l10n impact has been reviewed already by :stas

Thanks!

Comment 31

[Axel Hecht [:Pike]]

A review should not be mistaken for an approval.

Neither stas nor I can or should do approvals, all we can do is do technical reviews on whether the strings as exposed are probably going to work when localized or not.

Comment 32

[Alex Keybl [:akeybl]]

Comment on attachment 705277 [details]
Adding hints to Cost Control FTE

Hi Francisco - you may not have seen https://bugzilla.mozilla.org/show_bug.cgi?id=828476#c7, but all approvals should be completed during group triage with Mozilla involvement. Setting back to ?

Comment 33

[Maria Angeles Oteo (:oteo)]

(In reply to Alex Keybl [:akeybl] from comment #32)
> Comment on attachment 705277 [details]
> Adding hints to Cost Control FTE
> 
> Hi Francisco - you may not have seen
> https://bugzilla.mozilla.org/show_bug.cgi?id=828476#c7, but all approvals
> should be completed during group triage with Mozilla involvement. Setting
> back to ?

> This was not approved as part of triage. Placing back in nominate.

HI Alex,
first news about it, it is not the process explained in the meeting, wikis, or other communications... could you please clarify?

This bug was triaged with MOzilla team (as usual), Tef team attended that triage where it was flagged as tracking-b2g18+.So with approval-gaia-v1+ can be landed in v1-train.
Francisco Jordano has approval-gaia-v1 rights to do it.

I hope it's just a mistake because if something has changed in the process that's not the best way to communicate it.

Comment 34

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Alex Keybl [:akeybl] from comment #32)
> Comment on attachment 705277 [details]
> Adding hints to Cost Control FTE
> 
> Hi Francisco - you may not have seen
> https://bugzilla.mozilla.org/show_bug.cgi?id=828476#c7, but all approvals
> should be completed during group triage with Mozilla involvement. Setting
> back to ?

Hi Alex, definitely I didn't see it.

Comment 35

[Lukas Blakk [:lsblakk] use ?needinfo]

Is this looking to go to 1.0.1 or 1.1.0 - in the case of the former, then we will approve for v1-train landing, in the case of the latter landing to master branch has already occurred.

Comment 36

[Maria Angeles Oteo (:oteo)]

This is for the target market for 1.0.1. Please approve.

Comment 37

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 705277 [details]
Adding hints to Cost Control FTE

Approving for v1-train landing (v1.0.1)

Comment 38

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 59e298933f10c6a3301833064001ff0a3dc98d5d

Comment 39

[Delphine Lebédel [:delphine - Use needinfo]]

Something is unclear to me: Hints in Cost Control FTE are not localized in 2013-02-06-11-05-09 pvt nightly b2g18 build
Is this intentional?

Comment 40

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1