Closed
Bug 829601
Opened 11 years ago
Closed 11 years ago
Bugzilla::local_timezone should be stored in process_cache instead of request_cache
Categories
(Bugzilla :: Bugzilla-General, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: LpSolit, Assigned: LpSolit)
Details
(Keywords: perf)
Attachments
(1 file)
|
524 bytes,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
Bugzilla::local_timezone calls DateTime::TimeZone->new(name => 'local') which is very slow. It takes 0.2 second on my machine, for each page call. The local timezone won't change while a process is running, and so there is no need for this timezone object to be rebuilt again and again. It should be stored in process_cache instead of request_cache.
|
Assignee | |
Comment 1•11 years ago
|
||
Comment on attachment 701110 [details] [diff] [review] patch, v1 r=glob
Attachment #701110 -
Flags: review?(glob) → review+
|
|
Assignee | |
Updated•11 years ago
|
Flags: approval?
Flags: approval4.4+
Flags: approval+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla.pm Committed revision 8556. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/ modified Bugzilla.pm Committed revision 8504.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•