82967 - Bookmarks Sidebar Panel Issues

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Commands in bookmarks sidebar panel are not working because the node that 
contains the commands is not being included from the bookmarksOverlay.xul 
overlay. Patch fixes that & adds a Find button to the bookmarks sidebar panel 
for easier access to find.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: while we're here, add some styles to classic to make the panel look prettier

Comment 3

[Fabian Guisset]

r=fabian! for the two patches
this rules Ben!
Even drag and drop in sidebar works... excellent!
I propose you mail the drivers for 0.9.1 checkin, because this is a
high-visibility feature
Patches tested on linux and win2k.

Comment 4

[Doron Rosenberg (IBM)]

nominating for 0.9.1 - however, the .dtd are going to cause issues, l18n freeze
and such (i got hit and had to create a 2nd patch for the trunk once we branch
that introduces the .dtd changes).

os all since this also works on my linux box.

Comment 5

[Fabian Guisset]

Oh I forgot a nit... you can't use "f" as "find.accesskey" because there is
already a "f".

Comment 6

[Fabian Guisset]

blake, sr= please? this is really important for 0.9.1

Comment 7

[R.K.Aa.]

applying patch in attachment 36286 [details] [diff] [review] on linux i get:

patching file mozilla/xpfe/components/bookmarks/resources/bm-panel.xul
patch: **** malformed patch at line 15: <!-- XXX - would like to cut this
dependency out -->

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

*** Bug 79952 has been marked as a duplicate of this bug. ***

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

copying keywords from identical 79952.

Comment 10

[Blake Ross]

sr=blake
Good job fixing this nsbeta1+'er, Ben!

Comment 11

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

la.

Comment 13

[Gilles Durys]

*** Bug 85423 has been marked as a duplicate of this bug. ***

Comment 14

[Gilles Durys]

*** Bug 85449 has been marked as a duplicate of this bug. ***

Comment 15

[Claudius Gayle]

VERIFIED Fixed with 2001061404 builds

Comment 16

[Boris Zbarsky [:bzbarsky]]

*** Bug 88224 has been marked as a duplicate of this bug. ***