829838 - STK Send DTMF does not display any text

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Carol Yang [:cyang]]

In GCF TC 27.22.4.24.1.2, the test is ran as follows:

- Start GCF test which prompts for device power up
- After power up and network registration is successful, GCF test will send a SEND_DTMF proactive command to display "Send DTMF"

At this point, nothing is displayed even though this is sent:

RILContentHelper: Received message 'RIL:StkCommand': {"commandNumber":1,"typeOfCommand":20,"commandQualifier":0,"options":{"text":"Send DTMF"}}

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Yoshi, on DTMF command,I response you STK_RESULT_OK.

Is this correct? Is the DTMF sent by your platform code?

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Fernando R. Sela [:frsela] from comment #1)
> Yoshi, on DTMF command,I response you STK_RESULT_OK.
> 
> Is this correct? Is the DTMF sent by your platform code?
Yes, I think it's correct
Yes, I think DTMF is sent on gecko side.

https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/icc.js#L242

You also need to display it on screen, not only replying ok.

Comment 3

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Showed optional message on STK_CMD_SEND_* commands

The optional message is now displayed.

Yoshi, could you verify the DTMF tone is sent by the platform?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 702222 [details] [diff] [review]
Showed optional message on STK_CMD_SEND_* commands

I also wonder if you want to update the comment above?

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #5)
> Comment on attachment 702222 [details] [diff] [review]
> Showed optional message on STK_CMD_SEND_* commands
> 
> I also wonder if you want to update the comment above?

Comment removed
PR: https://github.com/mozilla-b2g/gaia/pull/7634
Landed: https://github.com/mozilla-b2g/gaia/commit/332f707c72d56399a7740039cd85ba509586fb20

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Fernando R. Sela [:frsela] from comment #3)
> Created attachment 702222 [details] [diff] [review]
> Showed optional message on STK_CMD_SEND_* commands
> 
> The optional message is now displayed.
> 
> Yoshi, could you verify the DTMF tone is sent by the platform?

For DTMF Tone, modem on Android has handled it so even gecko can only receive text message.

Comment 9

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #8)
> (In reply to Fernando R. Sela [:frsela] from comment #3)
> > Created attachment 702222 [details] [diff] [review]
> > Showed optional message on STK_CMD_SEND_* commands
> > 
> > The optional message is now displayed.
> > 
> > Yoshi, could you verify the DTMF tone is sent by the platform?
> 
> For DTMF Tone, modem on Android has handled it so even gecko can only
> receive text message.

You mean the UI should manage the DTMF tone?

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Fernando R. Sela [:frsela] from comment #9)
> > For DTMF Tone, modem on Android has handled it so even gecko can only
> > receive text message.
> 
> You mean the UI should manage the DTMF tone?

No, neither Gecko nor Gaia should handle it, because they cannot. The tones are already handled in modem.

Comment 11

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #10)
> (In reply to Fernando R. Sela [:frsela] from comment #9)
> > > For DTMF Tone, modem on Android has handled it so even gecko can only
> > > receive text message.
> > 
> > You mean the UI should manage the DTMF tone?
> 
> No, neither Gecko nor Gaia should handle it, because they cannot. The tones
> are already handled in modem.

So, if no DTMF is sent, who should check this issue? RIL guys?

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.

Comment 13

[amiller]

Test case not needed in Moztrap for this issue.