Closed
Bug 830221
Opened 11 years ago
Closed 6 years ago
Remove nsIDOMDOMImplementation
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: dzbarsky, Assigned: adrian17)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
12.57 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
12.56 KB,
patch
|
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
59 bytes,
text/x-review-board-request
|
bzbarsky
:
review+
|
Details |
It's used by 2 addons, but they both list a maxVersion of 3.6
Reporter | ||
Updated•11 years ago
|
Attachment #701677 -
Flags: review?(bzbarsky)
Reporter | ||
Updated•11 years ago
|
Attachment #701677 -
Attachment is patch: true
Comment 1•11 years ago
|
||
Peanut gallery here: what's the rationale for this?
Comment 2•11 years ago
|
||
Removing no-longer-needed code.
Comment 3•11 years ago
|
||
Comment on attachment 701677 [details] [diff] [review] Patch r=me if you've tested that trying to install those addons from AMO on a current build fails.
Attachment #701677 -
Flags: review?(bzbarsky) → review+
Reporter | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d88715bba2ca
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d88715bba2ca
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Comment 6•11 years ago
|
||
So we removed DOMImplementation? https://bugzilla.mozilla.org/show_bug.cgi?id=796903#c10 https://bugzilla.mozilla.org/show_bug.cgi?id=796903#c14 https://groups.google.com/forum/?fromgroups=#!topic/mozilla.dev.apps.firefox/GFmju3r2GY4
Comment 7•11 years ago
|
||
Hmm. Binary addons can still use mozilla::dom::DOMImplementation. But if you feel like making them do that is not reasonable then we do in fact need to back this out. :( Peter?
Flags: needinfo?(peterv)
Comment 8•11 years ago
|
||
How can binary addons use DOMImplementation?
Comment 9•11 years ago
|
||
Hmm. I guess the main stumbling block is that CreateDocument is non-virtual? Or is there something else I'm missing?
Comment 10•11 years ago
|
||
Yes, we need some way to create documents in binary addons.
Reporter | ||
Comment 11•11 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/ccc0d4c2ad6f
Status: RESOLVED → REOPENED
Flags: needinfo?(peterv)
Resolution: FIXED → ---
Reporter | ||
Comment 12•11 years ago
|
||
[Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Breaks some binary addons Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): Low risk String or UUID changes made by this patch: None
Attachment #724139 -
Flags: approval-mozilla-aurora?
Reporter | ||
Updated•11 years ago
|
Attachment #724139 -
Attachment description: Patch → Backout patch
Comment 13•11 years ago
|
||
(In reply to David Zbarsky (:dzbarsky) from comment #11) > Backed out in > https://hg.mozilla.org/integration/mozilla-inbound/rev/ccc0d4c2ad6f Merge of backout: https://hg.mozilla.org/mozilla-central/rev/ccc0d4c2ad6f
Updated•11 years ago
|
Attachment #724139 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 14•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/fae605ea8ef7
Updated•11 years ago
|
Target Milestone: mozilla21 → ---
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Assignee: dzbarsky → adrian.wielgosik
Comment 16•6 years ago
|
||
mozreview-review |
Comment on attachment 8950359 [details] Bug 830221 - Remove nsIDOMDOMImplementation. https://reviewboard.mozilla.org/r/219586/#review225388 r=me, given that binary addons are no more.
Attachment #8950359 -
Flags: review?(bzbarsky) → review+
Comment 17•6 years ago
|
||
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e234a362e55 Remove nsIDOMDOMImplementation. r=bz
Comment 18•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5e234a362e55
Status: REOPENED → RESOLVED
Closed: 11 years ago → 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•