830333 - the comment box should be hidden if check_can_change_field() reports the user is unable to comment on the bug

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[:glob ✱]

if an extension uses the bug_check_can_change_field hook to indicate that a user is unable to comment on a bug, the comment ui is displayed, but submission results in:

> You tried to change the Comment field, but only a user with the required permissions may change that field.

we should hide the comment field if the user is unable to comment on a bug, and replace it with a message indicating that they are unable to comment.

Comment 1

[Simon Green]

test

Comment 2

[Simon Green]

Attachment: v1 patch

Sorry about the last comment. Did test in the wrong window.

Regards,
Hugo

Comment 3

[Simon Green]

QA Contact: [e-mail] → [e-mail]

Hi Bryon,

Why was I made the QA contact of this bug? Can you please let me know what is involved in this?

Regards,
Hugo

Comment 4

[:glob ✱]

(In reply to Hugo Seabrook from comment #3)
> QA Contact: [e-mail] → [e-mail]
> 
> Hi Bryon,

byron :)

> Why was I made the QA contact of this bug? Can you please let me know what
> is involved in this?

oops, meant to make you the assignee.  fixed.

Comment 5

[:glob ✱]

Comment on attachment 703273 [details] [diff] [review]
v1 patch

r=glob

>+        [% ELSE %]
>+          You are unable to make an additional comment on this bug.
>+        [% END %]

this should be wrapped inside a <p> block to make it more readable.
can be fixed on commit.

Comment 6

[:glob ✱]

actually, the following looks better, and is consistent with the "you must be logged in" message.

[% ELSE %]
  <fieldset>
    <legend>Note</legend>
    You are unable to make an additional comment on this [% terms.bug %].
  </fieldset>
[% END %]

i can make this change on commit.

Comment 7

[:glob ✱]

Comment on attachment 703273 [details] [diff] [review]
v1 patch

dkl pointed out that the [reply] link in existing comments also needs to be hidden if users are not able to add new comments.

Comment 8

[Simon Green]

Attachment: v2 patch

We also need to hide the private checkbox too

Comment 9

[:glob ✱]

Comment on attachment 708520 [details] [diff] [review]
v2 patch

r=glob

Comment 10

[Frédéric Buclin]

Comment on attachment 708520 [details] [diff] [review]
v2 patch

>=== modified file 'template/en/default/bug/edit.html.tmpl'

>+        [% ELSE %]
>+          You are unable to make an additional comment on this bug.
>+        [% END %]

Hugo, make sure to run runtests.pl before uploading a patch. You must replace the hardcoded 'bug' by [% terms.bug %]. Also, I wonder if 'unable' shouldn't be replaced by 'not allowed'.

Please fix that on checkin.

Comment 11

[Frédéric Buclin]

@glob: I will let you do the fixes on checkin.

Comment 12

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/bug/comments.html.tmpl
modified template/en/default/bug/edit.html.tmpl
Committed revision 8574.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified template/en/default/bug/comments.html.tmpl
modified template/en/default/bug/edit.html.tmpl
Committed revision 8515.

Comment 13

[Frédéric Buclin]

Added to relnotes for 4.4rc2.