Closed
Bug 830350
Opened 11 years ago
Closed 11 years ago
[Facebook import][FTE] Selection/Deselection of Facebook contacts should close after the import is finished.
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect)
Tracking
(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.0 fixed)
VERIFIED
FIXED
blocking-b2g | tef+ |
People
(Reporter: nhirata, Assigned: mbudzynski)
References
Details
(Whiteboard: [Triaged:1/17])
Attachments
(1 file, 1 obsolete file)
## Environment : Gecko http://hg.mozilla.org/releases/mozilla-b2g18/rev/8f2ef4998b60 Gaia df38c1bb813029f3ccfa4a997fb1529b3ff1a1ff BuildID 20130111230201 Version 18.0 Otoro ## Repro : 1. run the FTE, get to the import contact option 2. select import from facebook 3. sign in 4. select all friends and import ## Expected : once the import is done, it should exit the screen ## Actual : the selection screen is still up; you have to hit the x in order to exit. ## Note : 1. for FTE, it leaves the user in wondering what to do next. Bad FTE for importing facebook contacts
Updated•11 years ago
|
blocking-b2g: tef? → tef+
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mbudzynski
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #702339 -
Flags: review?(francisco.jordano)
Comment 2•11 years ago
|
||
Comment on attachment 702339 [details]
patch
Jose Manuel will do this review. He is in charge of keeping integration of FB sync in both places, ftu and contacts.
Thanks!
Attachment #702339 -
Flags: review?(francisco.jordano) → review?(jmcanterafonseca)
Assignee | ||
Comment 3•11 years ago
|
||
Ok, thanks!
Comment 4•11 years ago
|
||
Can we get more info here on what state this leaves the user in? If there is no way to tell that the import completed and there are still steps to complete in the FTE process then this is more likely to be a tef+.
blocking-b2g: tef+ → tef?
Keywords: qawanted
Updated•11 years ago
|
blocking-b2g: tef? → tef+
tracking-b2g18:
? → ---
Reporter | ||
Comment 5•11 years ago
|
||
The state is still on the selection of Facebook Friends page. It will end up confusing the user esp on a first time experience.
Keywords: qawanted
Updated•11 years ago
|
Whiteboard: [EU_TPE_TRIAGED]
Updated•11 years ago
|
Attachment #702339 -
Flags: review?(jmcanterafonseca) → review-
Comment 8•11 years ago
|
||
Attachment #702339 -
Attachment is obsolete: true
Attachment #703221 -
Flags: review?(fernando.campo)
Attachment #703221 -
Flags: review?(crdlc)
Updated•11 years ago
|
Whiteboard: [EU_TPE_TRIAGED] → [Triaged:1/17]
Comment 9•11 years ago
|
||
Comment on attachment 703221 [details]
Patch that includes the banner, refactors and removes unnecessary code
Tested and working like a charm. Thanks Jose
Attachment #703221 -
Flags: review?(fernando.campo) → review+
Comment 10•11 years ago
|
||
Fernando, did you test in contacts as well? thanks
Comment 11•11 years ago
|
||
No, sorry I didn't, only on FTU. Gime some minutes and I'll do ;)
Comment 12•11 years ago
|
||
Ok, tested in contacts, works well too. Just one weird thing. If I import contacts from fb during FTU, later I'm not able to update or remove them from Contacts settings (the facebook setting is disabled). Is this the expected behaviour? Should I file a new bug?
Flags: needinfo?(jmcf)
Comment 13•11 years ago
|
||
After talking with Jose Manuel and perform some more tests to nail it down, decided the error would be probably caused by lost connection, not by malfunction of the app, so forget my previous comment :D
Flags: needinfo?(jmcf)
Comment 14•11 years ago
|
||
Comment on attachment 703221 [details]
Patch that includes the banner, refactors and removes unnecessary code
Great work!
Attachment #703221 -
Flags: review?(crdlc) → review+
Comment 15•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/862e88fc423ce3890ce122c06bf512e9cfd2e29b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
status-b2g18:
--- → fixed
Comment 17•11 years ago
|
||
Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.
status-b2g18-v1.0.0:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•