830369 - Refactor ScriptDebugPrologue and ScriptDebugEpilogue to use AbstractFramePtr

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 701820 [details] [diff] [review]
Patch

Review of attachment 701820 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsdbgapi.cpp
@@ +114,4 @@
>      JSBool ok = okArg;
>  
> +    if (void *hookData = frame.maybeHookData()) {
> +        if (frame.isGlobalFrame() || frame.isEvalFrame()) {

It would seem to be clearer if the code defined isFramePushedByExecute() on AbstractFamePointer, and used it here.

::: js/src/vm/Stack.h
@@ +1935,1 @@
>  };

When was AbstractFramePtr defined?  I don't have the changeset with the initial definition of AbstractFramePtr in either my inbound or ionmonkey tree.

Comment 3

[Jan de Mooij [:jandem]]

(In reply to Kannan Vijayan [:djvj] from comment #2)
> When was AbstractFramePtr defined?  I don't have the changeset with the
> initial definition of AbstractFramePtr in either my inbound or ionmonkey
> tree.

Sorry, I should have mentioned this. I added it as TaggedFramePtr and renamed it to AbstractFramePtr in bug 829554 (just pushed the second patch there to inbound).

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/65747e07d9df