830553 - Make every single assert in nsWrapperCache.h fatal

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

There are a few of these NS_ASSERTIONs in nsWrapperCache, and they all look pretty awful. bz had a problem that took us a long time to pin down because it wasn't clear where the problem was. We should make these into MOZ_ASSERT to catch problems earlier.  And possibly consider making them crash in release builds...

Comment 1

[Boris Zbarsky [:bzbarsky]]

I think we should strongly consider making every single assert in nsWrapperCache.h fatal.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Andrew, are you taking this, or should I?  I have most of this patch already....  Would need to run it through try, I guess.

Comment 3

[Andrew McCreight [:mccr8]]

I haven't started on it. Feel free to do it if you want, or I can probably get to it in a day or two.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Make the asserts in nsWrapperCache.h fatal.

Try run at https://tbpl.mozilla.org/?tree=Try&rev=17680b7ab2c0

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 702135 [details] [diff] [review]
Make the asserts in nsWrapperCache.h fatal.

Review of attachment 702135 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/609b32dec10d

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/609b32dec10d