Closed Bug 830759 Opened 11 years ago Closed 11 years ago

The close button in the Variables View (e.g. for watch expressions) should only be shown on hover

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 21

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(2 files)

v1
5.99 KB, patch
msucan
: review+
Details | Diff | Splinter Review
v1.1
6.06 KB, patch
vporof
: review+
Details | Diff | Splinter Review 
      No description provided.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P3
Attached patch v1 — — Splinter Review 

        Attachment #706987 -
        Flags: review?(mihai.sucan)

    
  
Depends on: 831794

    
  
Blocks: 830325

    
    

    
  
Comment on attachment 706987 [details] [diff] [review]
v1

Looks good, but I don't see the Close button when I move focus from one property to another using the keyboard.

Giving r+ with the above use-case fixed.

        Attachment #706987 -
        Flags: review?(mihai.sucan) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1.1
        — 
          — Splinter Review
      

    


  
Close button is shown when variable or property is focused.

        Attachment #707019 -
        Flags: review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/03c38d3c4182
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: