831004 - STK GET_INPUT and GET_INKEY truncates displayed text

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Carol Yang [:cyang]]

For GET_INPUT and GET_INKEY proactive commands, if the text to display is very long, the text gets truncated. For example: 

- TC 27.22.4.2.1.6 displays: Enter "x". This command ins...
- TC 27.22.4.3.1.8 displays: ***1111111111###***22222...

Daniel, thoughts on the display being truncated? Can GCF tests like these be passed/waived?

Comment 1

[Daniel Coloma:dcoloma]

What is the expected behaviour? Showing the entire message? How long these messages are?

Comment 2

[Carol Yang [:cyang]]

(In reply to Daniel Coloma:dcoloma from comment #1)
> What is the expected behaviour? Showing the entire message? How long these
> messages are?

Daniel, these tests are meant to test the max length (160 characters) of the text string. Is showing a truncated message acceptable? Or would the preferred behavior be to show wrap-text?

Comment 3

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Looks like a UI issue. Gaia people may able to get this fixed much sooner than I can. :)

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

I'll check it.

Carol, could you copy here the proactive command sent by the test?

Thanks in advance.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

Triage: blocks 808607. TEF+

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Allow text-overflow on STK INPUT title

Comment 7

[Carol Yang [:cyang]]

(In reply to Fernando R. Sela [:frsela] from comment #4)
> I'll check it.
> 
> Carol, could you copy here the proactive command sent by the test?
> 
> Thanks in advance.

Fernando, this is the proactive command for 27.22.4.3.1.8:

D081B18103012300820281828D81A1042A2A2A313131313131313131312323232A2A2A323232323232323232322323232A2A2A333333333333333333332323232A2A2A343434343434343434342323232A2A2A353535353535353535352323232A2A2A363636363636363636362323232A2A2A373737373737373737372323232A2A2A383838383838383838382323232A2A2A393939393939393939392323232A2A2A303030303030303030302323239102A0A0

FYI, in case you need the proactive command for any other GCF TC, you can find it in the 3GPP TS 51.010. Just look for the TC number in there and you should be able to see the corresponding PDU.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 702797 [details]
Allow text-overflow on STK INPUT title

r+ but add the style in a css file instead of inlining it.

Comment 9

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #8)
> Comment on attachment 702797 [details]
> Allow text-overflow on STK INPUT title
> 
> r+ but add the style in a css file instead of inlining it.

Styles in the CSS.

Landed - https://github.com/mozilla-b2g/gaia/commit/efaef57c2321972c4c3c73793dd2c3ca76f4b42a

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.

Comment 11

[John Hammink]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?  Thanks.

Comment 12

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to John Hammink from comment #11)
> Can you please provide steps to verify this fix - as we will blackbox test
> from the UI?  Thanks.

Using a SIM card with a long text message into this kind of command.

Another way is to "simulate" the command (adding test code into system app) if you need it, I can send you a TEST patch

Comment 13

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to John Hammink from comment #11)
> Can you please provide steps to verify this fix - as we will blackbox test
> from the UI?  Thanks.

Also: 
Same as in https://bugzilla.mozilla.org/show_bug.cgi?id=836135#c19 but change the command with this one:



          var cmd = {
            "commandNumber":1,
            "typeOfCommand":34,
            "commandQualifier":1,
            "options":{
              "text":"A really long text: 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890 12345 67890",
              "minLength":1,
              "maxLength":10,
              "defaultText":"",
              "isAlphabet":false
            }

Comment 14

[amiller]

No need to create a TC in Moztrap for this defect.